-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix plug-in peerDep check #2067
Conversation
Signed-off-by: zFernand0 <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2067 +/- ##
=======================================
Coverage 90.93% 90.93%
=======================================
Files 616 616
Lines 17359 17359
Branches 3671 3672 +1
=======================================
Hits 15786 15786
Misses 1572 1572
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: zFernand0 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a couple suggestions about phrasing in typedoc 🙂
packages/imperative/src/imperative/src/plugins/PluginManagementFacility.ts
Outdated
Show resolved
Hide resolved
packages/imperative/src/imperative/src/plugins/PluginManagementFacility.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: zFernand0 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @zFernand0!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks @zFernand0!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only comment is on the example in the PR description.
A range of >=5.0.0-next.0 <5.0.0 would only permit the use pre-release versions. I think it would fail when that version becomes GA (5.0.0).
I think in practice, that a range of >=5.0.0-next.0 <6.0.0 would permit pre-release versions of 5.0.0, and permit every GA version of 5.x, but not permit any 6.x version.
…into fix/peer-dep-check Signed-off-by: zFernand0 <[email protected]>
This PR can wait until after to following PR is merged into |
…-dep-check Signed-off-by: zFernand0 <[email protected]>
Quality Gate passedIssues Measures |
Release succeeded for the The following packages have been published:
Powered by Octorelease 🚀 |
What It Does
Remove the warnings at plug-in install time that appear, even though the plug-in peerDep version-range satisfies the requirement.
How to Test
First you would want to reproduce the issue:
>=5.0.0-next.0 <5.0.0
.Then you can test this branch:
>=8.0.0-next.0 <8.0.0
Review Checklist
I certify that I have:
Additional Comments
This follows the same behavior as https://semver.npmjs.com/
@zowe/imperative
and>=5.0.0-next.0 <5.0.0
😋Also, this GIF might make things easier to review: