-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Apple Silicon support for Zowe daemon #1766
Conversation
Signed-off-by: Timothy Johnson <[email protected]>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #1766 +/- ##
==========================================
+ Coverage 92.71% 92.78% +0.06%
==========================================
Files 423 423
Lines 7165 7165
Branches 1308 1308
==========================================
+ Hits 6643 6648 +5
+ Misses 521 516 -5
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Timothy Johnson <[email protected]>
c118144
to
c4a8e6b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a Mac at hand, but I appreciate you taking the time IRL to walk me through the fix.
LGTM! 😋
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Kudos, SonarCloud Quality Gate passed! |
What It Does
Resolves #1764
How to Test
zowe daemon enable
followed by a CLI command to verify that the new daemon worksReview Checklist
I certify that I have:
Additional Comments
The universal binary is about twice as large as the old one, but I think the benefits make it worthwhile.