Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Apple Silicon support for Zowe daemon #1766

Merged
merged 5 commits into from
Aug 1, 2023

Conversation

t1m0thyj
Copy link
Member

@t1m0thyj t1m0thyj commented Jul 27, 2023

What It Does
Resolves #1764

How to Test

  • Download the MacOS artifact from this PR's workflow run: https://github.com/zowe/zowe-cli/actions/runs/5684509878
  • Extract the TGZ from the downloaded ZIP and rename it to "zowe-macos.tgz"
  • Navigate to the directory where Zowe CLI is installed and replace the TGZ in the "prebuilds" folder
  • Run zowe daemon enable followed by a CLI command to verify that the new daemon works

Review Checklist
I certify that I have:

  • tested my changes
    • Test on ARM Mac - tested on my local machine
    • Test on x86_64 Mac - tested in this workflow run
  • added/updated automated tests
  • updated the changelog
  • followed the contribution guidelines

Additional Comments
The universal binary is about twice as large as the old one, but I think the benefits make it worthwhile.

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.06% 🎉

Comparison is base (6945988) 92.71% compared to head (99809f0) 92.78%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1766      +/-   ##
==========================================
+ Coverage   92.71%   92.78%   +0.06%     
==========================================
  Files         423      423              
  Lines        7165     7165              
  Branches     1308     1308              
==========================================
+ Hits         6643     6648       +5     
+ Misses        521      516       -5     
  Partials        1        1              

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@t1m0thyj t1m0thyj force-pushed the feat/daemon-macos-universal branch 2 times, most recently from c118144 to c4a8e6b Compare July 31, 2023 16:01
@t1m0thyj t1m0thyj marked this pull request as ready for review July 31, 2023 17:59
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a Mac at hand, but I appreciate you taking the time IRL to walk me through the fix.
LGTM! 😋

@sonarcloud
Copy link

sonarcloud bot commented Aug 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@t1m0thyj t1m0thyj merged commit 1b90aff into master Aug 1, 2023
51 checks passed
@t1m0thyj t1m0thyj deleted the feat/daemon-macos-universal branch August 1, 2023 14:17
@t1m0thyj t1m0thyj added the release-current Indicates that there is no new functionality being delivered label Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-current Indicates that there is no new functionality being delivered
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Zowe daemon for Apple Silicon
3 participants