Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CLI package pointing to Zowe Artifactory #296

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

t1m0thyj
Copy link
Member

What It Does

Fixes an issue where npm-shrinkwrap.json file in CLI package on npmjs.org references Zowe Artifactory (zowe.jfrog.io).

How to Test

Run the repackage tar script locally and check the npm-shrinkwrap.json file in the resulting TGZ:

curl -fsL -o cli-8.8.3.tgz https://zowe.jfrog.io/zowe/api/npm/npm-local-release/@zowe/cli/-/@zowe/cli-8.8.3.tgz
bash scripts/repackage_tar.sh cli-8.8.3.tgz https://registry.npmjs.org/ 8.8.3

Review Checklist
I certify that I have:

Additional Comments

@t1m0thyj t1m0thyj force-pushed the ci/fix-rewrite-shrinkwrap branch 2 times, most recently from 54db6f1 to bd68297 Compare November 21, 2024 16:33
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @t1m0thyj!

@t1m0thyj t1m0thyj merged commit 83f5101 into master Nov 21, 2024
4 checks passed
@t1m0thyj t1m0thyj deleted the ci/fix-rewrite-shrinkwrap branch November 21, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

4 participants