Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Node 18 and 20 #141

Merged
merged 3 commits into from
Oct 19, 2023
Merged

Use Node 18 and 20 #141

merged 3 commits into from
Oct 19, 2023

Conversation

awharn
Copy link
Member

@awharn awharn commented Oct 17, 2023

What It Does
Use node 18 and 20 in workflows

How to Test

Review Checklist
I certify that I have:

Additional Comments

@awharn
Use Node 18 and 20
e42d6b0 
Signed-off-by: Andrew W. Harn <[email protected]>
@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

zFernand0
zFernand0 requested changes Oct 17, 2023
View reviewed changes
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unit test failure?

@awharn
Copy link
Member Author

awharn commented Oct 17, 2023

unit test failure?

I see that, needed all the pipelines to run across all the repos to surface things like this. Kind of strange that it is only occurring on Windows, yet the same change on V1 doesn't cause the error.

@awharn
Check something
75350f9 
Signed-off-by: Andrew W. Harn <[email protected]>
@awharn
Fix unit test to expect correct message
62bc876 
Signed-off-by: Andrew W. Harn <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Oct 18, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell E 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@awharn awharn requested a review from zFernand0 October 18, 2023 19:36
zFernand0
zFernand0 approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the code smell is just complaining about thow "string" instead of throw new Error("string")
not a big deal 😋

LGTM! 😋

@awharn awharn merged commit 86bebc5 into master Oct 19, 2023
17 of 18 checks passed
@awharn awharn deleted the update-workflows-v2 branch October 19, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zFernand0 zFernand0 zFernand0 approved these changes

@gejohnston gejohnston gejohnston approved these changes

@traeok traeok Awaiting requested review from traeok

@KevinLoesch1 KevinLoesch1 Awaiting requested review from KevinLoesch1

@ATorrise ATorrise Awaiting requested review from ATorrise

Assignees
No one assigned
Labels
no-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@awharn @codecov-commenter @gejohnston @zFernand0