Remove need for loopback when using callService, callRootService #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 1000TurquoisePogs <[email protected]>
|
Hi |
1000TurquoisePogs
changed the title
DivergentEuropeans
approved these changes
Aug 3, 2021
| this.urlPrefix = urlPrefix; | ||
| if (!environment.loopbackConfig.port) { | ||
| installLog.severe(`ZWED0003E`, loopbackConfig); //installLog.severe(`loopback configuration not valid,`,loopbackConfig, `loopback calls will fail!`); | ||
| } | ||
| this.environment = environment; | ||
| this.isAgentService = isAgentService; | ||
| } | ||
| WebServiceHandle.prototype = { | ||
| constructor: WebServiceHandle, |
There was a problem hiding this comment.
The comment below can be updated to include turning off HTTP call to localhost by setting node.internalRouting=true in the server config.
| requestOptions.path = this.environment.agentRequestOptions.apimlPrefix + requestOptions.path; | ||
| } | ||
| httpOrHttps = requestOptions.protocol == 'http:' ? http : https; | ||
| console.log(`call agent direct`, requestOptions.path, requestOptions.hostname); |
There was a problem hiding this comment.
Is there a reason why we're using console.log instead of utilLog ?
There was a problem hiding this comment.
Thought I fixed every occurrence. Will fix now.
lchudinov
approved these changes
Aug 3, 2021
There was a problem hiding this comment.
It works fine both with and without APIML. zowe/sample-angular-app#62 works fine, too. It looks safe to merge after removing(or replacing) console.log.
|
Sorry, this was actually the wrong branch to review. #321 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: 1000TurquoisePogs [email protected]
Proposed changes
callService and callRootService currently do a loopback where there's a request from app-server to itself in order to reach the right part of the code to handle a request. This is overhead and causes ip config complications about how app-server reaches itself.
This PR fixes the problem in two ways.
Note 2, inter-server direct routing is disabled here for compatibility. It should be very compatible, but just dont want to disrupt behavior in v1. In zowe v2, we should switch this to enabled by default. The behavior can be enabled by setting the property
node.internalRouting=truein the server config.Type of change
Please delete options that are not relevant.
PR Checklist
Please delete options that are not relevant.
Testing
Case 1)
To test, you should be attempting login to desktop with and without apiml.
Without apiml, the code should contact zss directly. With apiml, it should contact apiml to contact zss.
If login succeeds in both cases, then this is working.
Case 2)
Test inter-plugin service calls using this PR zowe/sample-angular-app#62
I sent a small message in postman and observed the following to prove it was working:
Further comments