Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encoding the data content in the URL #315

Merged
merged 3 commits into from
Jan 6, 2023
Merged

Conversation

AdarshdeepCheema
Copy link
Contributor

@AdarshdeepCheema AdarshdeepCheema commented Dec 19, 2022

Signed-off-by: Adarshdeep Cheema [email protected]

PROBLEM: When accessing the desktop using gateway port, then trying opening a file or DS will result in 400 BAD REQUEST in browser, because the URL is not encoded properly

Proposed changes

This PR addresses Issue: [Link to Github issue within https://github.com/zowe/zlux/issues if any]

This PR depends upon the following PRs:

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Change in a documentation
  • Refactor the code
  • Chore, repository cleanup, updates the dependencies.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

PR Checklist

Please delete options that are not relevant.

  • If the changes in this PR are meant for the next release / mainline, this PR targets the "staging" branch.
  • My code follows the style guidelines of this project (see: Contributing guideline)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes
  • video or image is included if visual changes are made
  • Relevant update to CHANGELOG.md
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works, or describe a test method below

Testing

Further comments

Signed-off-by: Adarshdeep Cheema <[email protected]>
Signed-off-by: Adarshdeep Cheema <[email protected]>
Signed-off-by: Adarshdeep Cheema <[email protected]>
@pull-request-size pull-request-size bot added size/S and removed size/XS labels Jan 6, 2023
@1000TurquoisePogs 1000TurquoisePogs merged commit 8954c67 into v2.x/staging Jan 6, 2023
@AdarshdeepCheema AdarshdeepCheema deleted the encodeURL branch January 6, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants