open file at a specific line using copied link/URL

[AdarshdeepCheema]

Signed-off-by: Adarshdeep Cheema [email protected]

Proposed changes

This PR addresses Issue: [Link to Github issue within https://github.com/zowe/zlux/issues if any]

This PR depends upon the following PRs:

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Change in a documentation
• Refactor the code
• Chore, repository cleanup, updates the dependencies.
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

PR Checklist

Please delete options that are not relevant.

• If the changes in this PR are meant for the next release / mainline, this PR targets the "staging" branch.
• My code follows the style guidelines of this project (see: Contributing guideline)
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• New and existing unit tests pass locally with my changes
• video or image is included if visual changes are made
• Relevant update to CHANGELOG.md
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works, or describe a test method below

Testing

Further comments

[DivergentEuropeans]

I'm not able to remove the highlight from the page once it's on there. I can remove it, if the line is empty but if I delete the line, and type over it, the highlight comes back. The highlight can also be shifted around using linebreaks (see screenshot). I think you're opening a can of worms here to bug test this UX, I would recommend just sticking to highlighting the line number instead of the line itself. The rest of the PR I love, the UX just feels buggy

[DivergentEuropeans]

I think you resolved this but forgot to remove the 2nd snackbar:
https://github.com/zowe/zlux-editor/pull/308/files#diff-f1f6be017c15d827097c4d23b9480ce78315847ff3006f848c770c1cbed1eeebR278

[AdarshdeepCheema]

I'm not able to remove the highlight from the page once it's on there. I can remove it, if the line is empty but if I delete the line, and type over it, the highlight comes back. The highlight can also be shifted around using linebreaks (see screenshot). I think you're opening a can of worms here to bug test this UX, I would recommend just sticking to highlighting the line number instead of the line itself. The rest of the PR I love, the UX just feels buggy

Changed the decoration to the line number instead of line content and now we will remove the decoration if the user tries to edit the file

Screen.Recording.2022-11-17.at.11.17.39.AM.mov

[AdarshdeepCheema]

I think you resolved this but forgot to remove the 2nd snackbar: https://github.com/zowe/zlux-editor/pull/308/files#diff-f1f6be017c15d827097c4d23b9480ce78315847ff3006f848c770c1cbed1eeebR278

Fixed/Removed

[DivergentEuropeans]

Changes addressed, this looks great. We just need to document this now @AdarshdeepCheema