Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop the event to propagate to the parent component, when closing the file tab #294

Merged
merged 2 commits into from
Aug 19, 2022

Conversation

AdarshdeepCheema
Copy link
Contributor

@AdarshdeepCheema AdarshdeepCheema commented Aug 18, 2022

Signed-off-by: AdarshdeepCheema [email protected]

Proposed changes

This PR addresses Issue: [Link to Github issue within https://github.com/zowe/zlux/issues if any]

This PR depends upon the following PRs:

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Change in a documentation
  • Refactor the code
  • Chore, repository cleanup, updates the dependencies.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

PR Checklist

Please delete options that are not relevant.

  • If the changes in this PR are meant for the next release / mainline, this PR targets the "staging" branch.
  • My code follows the style guidelines of this project (see: Contributing guideline)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes
  • video or image is included if visual changes are made
  • Relevant update to CHANGELOG.md
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works, or describe a test method below

Testing

Further comments

Signed-off-by: AdarshdeepCheema <[email protected]>
@AdarshdeepCheema AdarshdeepCheema changed the title Stop the event to propagate to the parent when closing the file tab Stop the event to propagate to the parent component, when closing the file tab Aug 18, 2022
@TaoYeNa
Copy link

TaoYeNa commented Aug 19, 2022

Hi there, this change does not work on my device. For example we have file1 and file2, lets say we currently select file1, when we close file1, the cotent of file1 was still on the screen. Instead, we should select file2. If we are on file2 and we wanna close file1 then we should be getting the same content which from file2 instead of file1.

@AdarshdeepCheema
Copy link
Contributor Author

AdarshdeepCheema commented Aug 19, 2022

Hi there, this change does not work on my device. For example we have file1 and file2, lets say we currently select file1, when we close file1, the cotent of file1 was still on the screen. Instead, we should select file2. If we are on file2 and we wanna close file1 then we should be getting the same content which from file2 instead of file1.

I am unable to reproduce the scenario that you mentioned with this change. @TaoYeNa

@DivergentEuropeans DivergentEuropeans merged commit e6a1fad into v2.x/staging Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants