Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JCL syntax hiliter update #288

Merged
merged 5 commits into from
Nov 9, 2022
Merged

JCL syntax hiliter update #288

merged 5 commits into from
Nov 9, 2022

Conversation

Martin-Zeithaml
Copy link
Contributor

Signed-off-by: Martin Zeithaml [email protected]

Proposed changes

Small update to JCL hiliter.

This PR addresses Issue: #839

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

PR Checklist

Please delete options that are not relevant.

  • My code follows the style guidelines of this project (see: Contributing guideline)
  • I have commented my code, particularly in hard-to-understand areas

Testing

Manual testing:

  • JCL syntax by comparing editor with and without fix
  • Debug messages in developer's console are shown only when production is set to false

Signed-off-by: Martin Zeithaml <[email protected]>
@Martin-Zeithaml
Copy link
Contributor Author

When this PR will be merged, I will do the same for v2.x. It is possible, that during the testing more changes will be done.

Copy link
Member

@DivergentEuropeans DivergentEuropeans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an excellent change, and I manually compared this, what we have, and what ISPF has, and for all of my files tested, this is better highlighting - thank you very much! @Martin-Zeithaml
A huge improvement

@Martin-Zeithaml
Copy link
Contributor Author

I have updated the CHANGELOG and also setting of jclDebug variable.

Copy link
Member

@DivergentEuropeans DivergentEuropeans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@struga0258 was kind enough to test, merging. Thank you 👍 @Martin-Zeithaml

@DivergentEuropeans DivergentEuropeans merged commit f94cc7a into zowe:v1.x/staging Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants