No more ngx-monaco #155
No more ngx-monaco #155
Conversation
…Remove ngx-monaco. Reduce dependency on globals. Update packages to reduce npm audit warnings Signed-off-by: 1000TurquoisePogs <[email protected]>
Signed-off-by: 1000TurquoisePogs <[email protected]>
There was a problem hiding this comment.
Code-wise, other than the small things I mentioned, things look generally OK to me. However, I am getting some very funky visual problems, which leads to me to believe that something is wrong with the way CSS is being imported, using Node 10.16.3, Windows 10, Chrome
Broken highlighting, line numbers not showing, weird artifacts & cursor does not update with the correct location.
Functionally, it seems to work OK, Ctrl + A correctly selects all even if visually it doesn't show it, cursor types from the correct spot even if visually it doesn't show it
Syntax highlighting works though
| "source-map-loader": "~0.2.4", | ||
| "style-loader": "~0.22.1", | ||
| "ts-loader": "~4.4.2", | ||
| "ts-node": "~4.1.0", | ||
| "tslint": "~5.10.0", | ||
| "typescript": "~2.7.2", | ||
| "typescript": "~3.7.0", |
There was a problem hiding this comment.
Angular 9 supports 3.7 I believe, Angular 8 supports 3.4
So don't remember what Angular version we're responsible for (6?), just making sure you have the version you intended it to be in this PR
There was a problem hiding this comment.
Yeah, it's not because I wanted to but because monaco itself needs typescript of a certain version. This seems to work even though angular doesnt officially support it. I think it just means "dont do newer typescript features with older angular", which is fine because here, the newer typescript features are being used for monaco, which lives outside of angular.
webClient/src/app/editor/code-editor/monaco/monaco.component.ts
Outdated
Show resolved
Hide resolved
webClient/src/app/editor/code-editor/monaco/monaco.component.ts
Outdated
Show resolved
Hide resolved
webClient/src/app/editor/code-editor/monaco/monaco.component.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: 1000TurquoisePogs <[email protected]>
Signed-off-by: 1000TurquoisePogs <[email protected]>
Update monaco to newest version. Remove need for native compilation. Remove ngx-monaco. Reduce dependency on globals. Update packages to reduce npm audit warnings
Signed-off-by: 1000TurquoisePogs [email protected]