TLS FTP support #53
Merged
TLS FTP support #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…upport comming later Signed-off-by: 1000TurquoisePogs <[email protected]>
Signed-off-by: 1000TurquoisePogs <[email protected]>
timgerstel
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR alters the connection page to give the option for the FTP session to use TLS.
The FTP library we use already had TLS support, so this is only about providing prompts for the user to choose it or not.
By default, the page looks the same as before: FTP without TLS is the default. Perhaps we should change that?
If they select "Use FTP over TLS", then a box expands to ask about tls min/max versions, and whether or not to accept invalid certificates.
About certificates:
node doesnt seem to have a hook for prompting the user if they want to accept a certificate that cant be verified. it's either strict verification or no verification.
so the user can click strict, and then if it fails, can try again without strict.
but we need an easy way for users to provide CAs for verifying certificates.
it seems there are node libraries for reading system keyrings for that purpose, and we should get one.
but it could also be possible to just pick up CAs found in ~/.zowe/zen/cas