Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set correct run-time directory from SMPE install type #51

Merged
merged 8 commits into from
Jan 8, 2024

Conversation

timgerstel
Copy link
Contributor

@timgerstel timgerstel commented Oct 2, 2023

This pull request implements the following feature:

  • Properly track smpe directory via user input
  • Prevent installation stage from creating datasets/downloading pax/running 'zwe init' if the user has chosen SMPE install type (these steps will have been done by the SMPE process)
  • Update wording in description of SMPE dir input field

Copy link
Member

@1000TurquoisePogs 1000TurquoisePogs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot properly test this due to an error I am getting

Error occurred in handler for 'set-config-by-key': TypeError: Cannot read properties of null (reading 'properties')
at ConfigurationStore.validateWithSchema (/home/me/bt/zen/.webpack/main/index.js:30877:33)
at ConfigurationStore.setConfigByKey (/home/me/bt/zen/.webpack/main/index.js:30905:18)
at PlanningActions. (/home/me/bt/zen/.webpack/main/index.js:29866:68)
at Generator.next ()
at /home/me/bt/zen/.webpack/main/index.js:29745:71
at new Promise ()
at webpack_modules../src/actions/PlanningActions.ts.__awaiter (/home/me/bt/zen/.webpack/main/index.js:29741:12)
at PlanningActions.setConfigByKey (/home/me/bt/zen/.webpack/main/index.js:29865:16)
at /home/me/bt/zen/.webpack/main/index.js:29971:61
at Generator.next ()
[2898772:1003/131914.703293:INFO:CONSOLE(0)] "Uncaught (in promise) Error: Error invoking remote method 'set-config-by-key': TypeError: Cannot read properties of null (reading 'properties')", source: http://localhost:3000/main_window#/wizard (0)

But I now believe the SMPE runtime directory prompt to be redundant, so would like to test.

The radio to select SMPE/download/upload options comes AFTER you specify where you will install zowe to, which is the previous page.
Due to this, I think you're actually prompting the user twice for the same info.

Further, with SMPE we also need to know where datasets were put but again I think that's asked on the next page, anyway.

image

image

image

@sakshibobade21
Copy link
Contributor

The PR looks good to me. Please resolve the conflicts before merging.

@sakshibobade21 sakshibobade21 self-requested a review December 8, 2023 10:22
Copy link
Member

@DivergentEuropeans DivergentEuropeans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a small issue in that Validate Location when validation fails, does not give an error or some UX indication

image

But not a problem with the PR @timgerstel just a feature request so I've updated this PR w/ merge conflicts & going to merge

@DivergentEuropeans DivergentEuropeans merged commit 51b60ed into v2.x/staging Jan 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants