-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set correct run-time directory from SMPE install type #51
Conversation
Signed-off-by: Timothy Gerstel <[email protected]>
…install mvs button as SMPE users will already have the datasets created. Signed-off-by: Timothy Gerstel <[email protected]>
Signed-off-by: Timothy Gerstel <[email protected]>
Signed-off-by: Timothy Gerstel <[email protected]>
Signed-off-by: Timothy Gerstel <[email protected]>
Signed-off-by: Timothy Gerstel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot properly test this due to an error I am getting
Error occurred in handler for 'set-config-by-key': TypeError: Cannot read properties of null (reading 'properties')
at ConfigurationStore.validateWithSchema (/home/me/bt/zen/.webpack/main/index.js:30877:33)
at ConfigurationStore.setConfigByKey (/home/me/bt/zen/.webpack/main/index.js:30905:18)
at PlanningActions. (/home/me/bt/zen/.webpack/main/index.js:29866:68)
at Generator.next ()
at /home/me/bt/zen/.webpack/main/index.js:29745:71
at new Promise ()
at webpack_modules../src/actions/PlanningActions.ts.__awaiter (/home/me/bt/zen/.webpack/main/index.js:29741:12)
at PlanningActions.setConfigByKey (/home/me/bt/zen/.webpack/main/index.js:29865:16)
at /home/me/bt/zen/.webpack/main/index.js:29971:61
at Generator.next ()
[2898772:1003/131914.703293:INFO:CONSOLE(0)] "Uncaught (in promise) Error: Error invoking remote method 'set-config-by-key': TypeError: Cannot read properties of null (reading 'properties')", source: http://localhost:3000/main_window#/wizard (0)
But I now believe the SMPE runtime directory prompt to be redundant, so would like to test.
The radio to select SMPE/download/upload options comes AFTER you specify where you will install zowe to, which is the previous page.
Due to this, I think you're actually prompting the user twice for the same info.
Further, with SMPE we also need to know where datasets were put but again I think that's asked on the next page, anyway.
The PR looks good to me. Please resolve the conflicts before merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a small issue in that Validate Location when validation fails, does not give an error or some UX indication
But not a problem with the PR @timgerstel just a feature request so I've updated this PR w/ merge conflicts & going to merge
…cement/smpeInstall Signed-off-by: Leanid Astrakou <[email protected]>
This pull request implements the following feature: