Integrate Monaco Editor in ZEN #42
Conversation
sakshibobade21
commented
Sep 12, 2023
•
sakshibobade21
commented
- Incorporate Monaco Editor to ZEN with the Schema and Yaml Validations for the entire zowe.yaml, not just the subschema
- Integrating the editor’s with the configuration service
- Automatically update the JSON forms with the corresponding editor’s content if it adheres to schema and yaml validation
- Enable bidirectional synchronization: changes made in the form must reflect in the editor
- Centralized the shared code for the editor
src/services/configService.ts
Outdated
| @@ -1,13 +1,32 @@ | |||
| import { flatten, unflatten } from 'flat'; | |||
There was a problem hiding this comment.
Why is there two configservice.ts? One is ConfigService.ts the other is configService.ts
There was a problem hiding this comment.
Looks like this file should just be deleted
There was a problem hiding this comment.
This double file messed up my git shell so bad lol i cant switch branches now
|
Tested the schema validation and it works as expected, rejects things that do not adhere:
On this UI my one note is that the editor should be autofocused when this popup appears, so if you press Ctrl+A on your keyboard all the text highlights without having to click the editor first. |
|
Overall i think this is a great addition, just a few minor things before I approve |
|
The installation stage doesnt autofill details from the example-zowe.yaml on the first run anymore btw, this may be a regression |
Deleting the duplicate file Signed-off-by: Sakshi Bobade <[email protected]>
|
There is another bug with this PR. I wanted to retest the autofill for the first run, so I deleted all of my cached data in the userData folder for Zen (%appdata/zowe-enterprise-necessity on Windows I think) and now I get this error: This does not happen on v2.x/staging. It looks like your code might not be handling the case where a yaml doesnt exist at all |
|
Created a new one. |
