Test certificate tab #266
Merged
Test certificate tab #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 2, 2024 23:33
Signed-off-by: hpathak <[email protected]>
Signed-off-by: hpathak <[email protected]>
struga0258
requested changes
Dec 5, 2024
| }) | ||
|
|
||
| test('test title of page & required fields', async ({ page }) => { | ||
| await page.waitForTimeout(5000); |
There was a problem hiding this comment.
can we remove all these timeouts, they are not doing anything.
| await expect(certificatePage.editor_title_element).toBeTruthy(); | ||
| await certificatePage.closeButton() | ||
| }) | ||
| test('test all available options for verify certificates', async ({ page }) => { |
There was a problem hiding this comment.
cant you do this in the first test?
| }); | ||
|
|
||
|
|
||
| test('test continue button is disable', async ({ page }) => { |
There was a problem hiding this comment.
can't you merge this test with the completed one?
| }); | ||
|
|
||
|
|
||
| test('Test view job output button', async ({ page }) => { |
Signed-off-by: hpathak <[email protected]>
struga0258
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR addresses Issue: [Link to Github issue within https://github.com/zowe/zen/issues if any]
This PR depends upon the following PRs:
Type of change
Please delete options that are not relevant.
PR Checklist
Please delete options that are not relevant.
Testing
Further comments