Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip VSAM Init #262

Merged
merged 19 commits into from
Oct 15, 2024
Merged

Skip VSAM Init #262

merged 19 commits into from
Oct 15, 2024

Conversation

sakshibobade21
Copy link
Contributor

@sakshibobade21 sakshibobade21 commented Oct 3, 2024

Proposed changes

This PR addresses Issue:

  1. Implements a check to determine if the Zowe PAX version is greater than or equal to 3.
  2. If version is >= 3, displays a dropdown for users to select the storage mode, pre-filled with the value from the YAML file if available.
  3. If the user selects VSAM, the VSAM initialization form is displayed.
  4. If Infinispan is chosen, the VSAM initialization form is hidden.
  5. If the version is >= 3 and the VSAM initialization is skipped, the review stage will not block the user from proceeding to the final stage.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Change in a documentation
  • Refactor the code
  • Chore, repository cleanup, updates the dependencies.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

PR Checklist

Please delete options that are not relevant.

  • If the changes in this PR are meant for the next release / mainline, this PR targets a "staging" branch.
  • My code follows the style guidelines of this project (see: Contributing guideline)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • New and existing unit tests pass locally with my changes
  • video or image is included if visual changes are made
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works, or describe a test method below

Testing

Further comments

@timgerstel
Copy link
Contributor

This PR was reviewed during a team meeting, as well as reviewed independently by Sean and myself. I did not personally test this but the code looks good so approving

@1000TurquoisePogs 1000TurquoisePogs merged commit 1c2008f into v2.x/staging Oct 15, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

3 participants