Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PoC for Mobile App #40

Closed
wants to merge 1 commit into from
Closed

PoC for Mobile App #40

wants to merge 1 commit into from

Conversation

lchudinov
Copy link
Contributor

@lchudinov lchudinov commented Jun 11, 2020 •
edited
Loading

@lchudinov lchudinov marked this pull request as draft June 11, 2020 05:14
@lchudinov lchudinov force-pushed the feature/poc-for-mobile-app branch 5 times, most recently from c33a986 to e45deb1 Compare June 18, 2020 08:24
@lchudinov lchudinov force-pushed the feature/poc-for-mobile-app branch from d23b61d to 217e93a Compare June 22, 2020 08:10
@lchudinov lchudinov marked this pull request as ready for review June 22, 2020 09:49
1000TurquoisePogs
1000TurquoisePogs reviewed Jul 15, 2020
View reviewed changes
Copy link
Member

@1000TurquoisePogs 1000TurquoisePogs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that you made alternative implementations for context objects, build files, and basically made a mobile window manager in order to have the login page. Shouldnt most of this code be moved to zlux-app-manager?

mobileClient/angularMobileApp/src/app/mobile.module.ts
multi: true,
},
{ provide: PluginManager, useValue: CordovaResources.pluginManager },
{ provide: Angular2InjectionTokens.L10N_CONFIG, useValue: { defaultLocale: { languageCode: 'en' }, providers: [] } },
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Detecting language on android is probably different from how we do it in the browser, but maintaining the providers separate from the code in zlux-app-manager/virtual-desktop will cause some duplication. Can it be avoided?

mobileClient/angularMobileApp/src/app/login/login.component.ts
@@ -0,0 +1,84 @@
/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file and many other files here seem to be an alternative window manager, as opposed to the two we currently have in zlux-app-manager/virtual-desktop/src/app/window-manager ... why dont we move the code there as a third window manager?

mobileClient/angularMobileApp/src/polyfills.ts
@@ -0,0 +1,101 @@
/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file is boilerplate that the angular apps already have. does it need to be duplicated?

mobileClient/angularMobileApp/tsconfig.json
@@ -0,0 +1,48 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file looks like the tsconfig files seen in zlux-app-manager/virtual-desktop/plugin-config
shouldnt it be moved there so that people who want to build mobile apps can extend a default configuration?

@lchudinov lchudinov force-pushed the feature/poc-for-mobile-app branch 2 times, most recently from e45deb1 to 217e93a Compare July 20, 2020 03:14
@lchudinov
Copy link
Contributor Author

I close this PR because I moved the code into zowe/zlux-app-manager#241

@lchudinov lchudinov closed this Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1000TurquoisePogs 1000TurquoisePogs 1000TurquoisePogs left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lchudinov @1000TurquoisePogs