-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add keyring support #31
Conversation
Signed-off-by: js665999 <[email protected]>
Signed-off-by: js665999 <[email protected]>
Signed-off-by: js665999 <[email protected]>
Mocha and Eslint both are reporting vulnerabilities on lodash - on their latest version - alternative use some other packages We need to add tests for new options here: we are failing one existing test:
and then we can approve and merge, |
Signed-off-by: Nakul Manchanda <[email protected]>
Signed-off-by: Nakul Manchanda <[email protected]>
Signed-off-by: Nakul Manchanda <[email protected]>
SonarCloud Quality Gate failed. 0 Bugs 73.0% Coverage The version of Java (1.8.0_242) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11. |
Signed-off-by: Nakul Manchanda <[email protected]>
Signed-off-by: Nakul Manchanda <[email protected]>
Signed-off-by: Nakul Manchanda <[email protected]>
Signed-off-by: Nakul Manchanda <[email protected]>
Refactored https Configuration and added test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me
adds ability to load certificates from keyrings on z/OS
new options:
-n, --keyring keyring name
-o, --keyring-owner keyring owner id
-l, --keyring-label keyring certificate label
keyring options are used when certificates are not loaded via -c and -k options