Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add keyring support #31

Merged
merged 10 commits into from
Jul 13, 2020
Merged

add keyring support #31

merged 10 commits into from
Jul 13, 2020

Conversation

js665999
Copy link

adds ability to load certificates from keyrings on z/OS
new options:
-n, --keyring keyring name
-o, --keyring-owner keyring owner id
-l, --keyring-label keyring certificate label

keyring options are used when certificates are not loaded via -c and -k options

Signed-off-by: js665999 <[email protected]>
@js665999 js665999 requested a review from jordanCain June 24, 2020 14:41
js665999 added 2 commits July 2, 2020 14:17
Signed-off-by: js665999 <[email protected]>
Signed-off-by: js665999 <[email protected]>
@NakulManchanda
Copy link
Member

NakulManchanda commented Jul 8, 2020

Mocha and Eslint both are reporting vulnerabilities on lodash - on their latest version - alternative use some other packages
Will be outside scope of this PR to find those alternative so considering disabling audit to merge this one.

We need to add tests for new options here:
https://github.com/zowe/explorer-ui-server/tree/staging/test/https-combos

we are failing one existing test:

  1. test https combos
    using pfx-pass should return index.html when requesting /:

and then we can approve and merge,
i can add same.
thanks

Nakul Manchanda added 3 commits July 9, 2020 04:11
Signed-off-by: Nakul Manchanda <[email protected]>
Signed-off-by: Nakul Manchanda <[email protected]>
@sonarcloud
Copy link

sonarcloud bot commented Jul 9, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

73.0% 73.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_242) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

Nakul Manchanda added 4 commits July 9, 2020 11:42
Signed-off-by: Nakul Manchanda <[email protected]>
Signed-off-by: Nakul Manchanda <[email protected]>
Signed-off-by: Nakul Manchanda <[email protected]>
Signed-off-by: Nakul Manchanda <[email protected]>
@NakulManchanda
Copy link
Member

Refactored https Configuration and added test

@NakulManchanda NakulManchanda requested review from jackjia-ibm and removed request for jordanCain July 9, 2020 20:08
Copy link
Member

@jackjia-ibm jackjia-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants