Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyring support documentation #1214

Merged
merged 23 commits into from
Jul 28, 2020
Merged

Keyring support documentation #1214

merged 23 commits into from
Jul 28, 2020

Conversation

vit-tomica
Copy link
Contributor

Signed-off-by: Vit Tomica [email protected]

Documentation for configuration of certificates in a key ring
Related PR: zowe/zowe-install-packaging#1177

Is there a related issue for this PR?

Issue number:

Developer's Certificate of Origin (DCO)

@vit-tomica vit-tomica changed the title WIP - Keyring support WIP - Keyring support documentation May 14, 2020
Signed-off-by: Vit Tomica <[email protected]>
Signed-off-by: Vit Tomica <[email protected]>
Signed-off-by: Vit Tomica <[email protected]>
@vit-tomica vit-tomica changed the title WIP - Keyring support documentation Keyring support documentation May 27, 2020
@nannanli nannanli self-requested a review May 28, 2020 17:59
Copy link
Member

@nannanli nannanli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vit-tomica for the updates! I made some editorial changes. See d762ea4. Also moved z/OSMF workflow information to another location instead of this topic. One quick question, please see my comment.

docs/user-guide/configure-certificates.md Outdated Show resolved Hide resolved
Copy link
Contributor

@plavjanik plavjanik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have only one detail: both forms "key ring" and "keyring" are used both in the documentation and JCL comments

@plavjanik
Copy link
Contributor

Hello @nannanli, what was the reason to remove section "## Method 2: Configure Zowe certificates with z/OSMF Workflows"?

@nannanli
Copy link
Member

nannanli commented Jun 1, 2020

@plavjanik Hi Petr, sorry for the confusion. The z/OSMF workflow sections was moved to a separate chapter as part of the other documentation change. See https://github.com/zowe/docs-site/blob/docs-staging/docs/user-guide/configure-zowe-zosmf-workflow.md. I removed it to clean up the conflict. All z/OSMF workflow information are contained in a single topic now for clarity.

@nannanli
Copy link
Member

nannanli commented Jun 4, 2020

@vit-tomica Hi Vit, can this PR be merged?

@vit-tomica
Copy link
Contributor Author

@nannanli I would like to merge it approximately same time as the zowe/zowe-install-packaging#1177 PR. This is in a case that the review reveals some flaws that would have also impact on doc.

@nannanli nannanli added area: zos-install-upgrade Issues related to Zowe z/OS components installation, mostly using convenience build. type: enhancement New feature or request labels Jul 10, 2020
Signed-off-by: Vit Tomica <[email protected]>
…pport

# Conflicts:
#	docs/user-guide/configure-certificates.md
# Conflicts:
#	docs/user-guide/configure-certificates.md
@Joe-Winchester Joe-Winchester merged commit 564b9fc into docs-staging Jul 28, 2020
@Joe-Winchester Joe-Winchester deleted the keyring-support branch July 28, 2020 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: zos-install-upgrade Issues related to Zowe z/OS components installation, mostly using convenience build. type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants