New translator for LinkedIn post pages. #3373
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbeJellinek
requested changes
Oct 21, 2024
| // NOTE: This translator will only work if you are *not* logged into LinkedIn. Logged-in versions of the page do not include the necessary metadata. If you are logged into LinkedIn, you can open a private or incognito window to use the translator. // | ||
|
|
||
| function detectWeb(doc, url) { | ||
| if (url.includes('/posts/')) { |
There was a problem hiding this comment.
If scrape() only works when script[type="application/ld+json"] exists, we should check that here.
| } | ||
|
|
||
| newItem.forumTitle = "LinkedIn"; | ||
| newItem.postType = "LinkedIn Post"; |
There was a problem hiding this comment.
I don't know if we really need this - it's a forumPost on forumTitle "LinkedIn".
|
|
||
| newItem.forumTitle = "LinkedIn"; | ||
| newItem.postType = "LinkedIn Post"; | ||
| newItem.websiteType = "Social Media"; |
There was a problem hiding this comment.
Ditto - I don't think this is necessary for a citation.
There was a problem hiding this comment.
I wasn't sure about this. LinkedIn posts are in kind of a gray area between forum posts and blog posts.
|
Thanks! Some comments above. |
Accepted suggestion for modifying URL Co-authored-by: Abe Jellinek <[email protected]>
modified code style Co-authored-by: Abe Jellinek <[email protected]>
accepted change to push action Co-authored-by: Abe Jellinek <[email protected]>
Co-authored-by: Abe Jellinek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This translator will retrieve all relevant metadata and a snapshot from LinkedIn individual post pages. It will only work when not logged into LinkedIn, because the page structure is entirely different when viewed by a logged-in user. It will work properly in incognito/private windows.