[HotFix] HAL: Hotfix for identification failures #3077
Conversation
The HAL translator did not work at all with the new HAL site at a different domain. - Update target regex for the new domain `hal.science` - Update the element selector for the content-type label - Do some cleaning with raw content-type label text; update some labels - Fix a large number of ESLint errors Resolves zotero#3041
zoe-translates
force-pushed
the
HAL-hotfixes
branch
from
025aaea to
1a1feea
Compare
|
In the long run, we should probably just use the API; it supports OAI https://api.archives-ouvertes.fr/docs/oai Example: https://api.archives-ouvertes.fr/oai/hal/?verb=GetRecord&metadataPrefix=oai_dc&identifier=thouret%3Ahal-00328427 Meanwhile, this is a fix for the translator not being run at all, and possibly some wrong icon types displayed in Connector. (And superficial fixes for ESLint failures). The Library Catalog seems to have changed from "HAL archives ouvertes" to "HAL science ouverte". |
- Update selector for abstract (it now has a class list with more class names so the previous XPath failed). - Update the selector for PDF link. - Cosmetic fix: further fixes to the type identification (affecting the Connector icon, not the actual item's metadata).
| @@ -90,34 +98,33 @@ function doWeb(doc, url) { | |||
| for (var i in items) { | |||
| articles.push(i); | |||
| } | |||
| Zotero.Utilities.processDocuments(articles, scrape) | |||
| Zotero.Utilities.processDocuments(articles, scrape); | |||
| return true; | |||
There was a problem hiding this comment.
We don't actually check the return value of the selectItems callback (anymore?), so the consistent-return fix here is just to change the first return true; to return;.
There was a problem hiding this comment.
You are right about the callback return value being discarded. But because this is now already merged, I'm going to focus on substantive improvements next (for example, asyncify, use OAI for metadata, with speedup of saving multiple, etc.)
The HAL translator did not work at all with the new HAL site at a different domain.
hal.scienceResolves #3041 (Edit: also resolves #3045)