beck-online: Allow detection of proxied URLs #2624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a hack. EZproxy replaces dots with dashes in proxied HTTPS URLs, so the connector undoes that by replacing dashes with dots. Unfortunately, that means that beck-online.beck.de will be proxied to beck-online-beck-de and then de-proxied by the connector to beck.online.beck.de. Accepting a dot in addition to a dash sidesteps the issue.
|
What URL gets saved to Zotero in this case? |
|
Oh, that would seem to be a separate issue - the permalink There are also some tests that aren't detecting anymore, but I'll work on that in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a hack. EZproxy replaces dots with dashes in proxied HTTPS URLs, so the connector undoes that by replacing dashes with dots. Unfortunately, that means that
beck-online.beck.dewill be proxied tobeck-online-beck-deand then de-proxied by the connector tobeck.online.beck.de. Accepting a dot in addition to a dash sidesteps the issue.Fixes #2598.