Add UNZ Print Archive.js #1272
Merged
Add UNZ Print Archive.js #1272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ready for review
|
|
@adam3smith @zuphilip i have a bunch of translators ready for review but buried in the queue—wanted to make sure you saw |
|
@owcz thanks for the ping -- will try to get to soon-ish, but this week is still extraordinarily busy. |
|
Busy times for me as well... |
|
no worries, just wanted to put it on your radar |
It's fine for catalog entry URLs to go in item.url, so long as they provide some sort of full-text source for the item and would be useful to include in a citation. That is the case here, so we'll include them.
|
I'm sorry this sat in the backlog for so long! Great translator and a really cool site that I'm glad I know about now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Translator for UNZ.org periodical archive. Really powerful—works on every page (save for individual books without reviews, which don't have useful metadata and for which users are better off clicking through to their Internet Archive source).