-
Notifications
You must be signed in to change notification settings - Fork 756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Frieze.js #1259
Merged
Merged
Add Frieze.js #1259
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,233 @@ | ||
{ | ||
"translatorID": "7feb4b6c-05d6-4d61-bf0d-5e7f70c1ef0b", | ||
"label": "Frieze", | ||
"creator": "czar", | ||
"target": "^https?://(www\\.)?frieze\\.com", | ||
"minVersion": "3.0", | ||
"maxVersion": "", | ||
"priority": 100, | ||
"inRepository": true, | ||
"translatorType": 4, | ||
"browserSupport": "gcsibv", | ||
"lastUpdated": "2018-07-08 13:46:04" | ||
} | ||
|
||
/* | ||
***** BEGIN LICENSE BLOCK ***** | ||
|
||
Copyright © 2018 czar | ||
http://en.wikipedia.org/wiki/User_talk:Czar | ||
|
||
This file is part of Zotero. | ||
|
||
Zotero is free software: you can redistribute it and/or modify | ||
it under the terms of the GNU Affero General Public License as published by | ||
the Free Software Foundation, either version 3 of the License, or | ||
(at your option) any later version. | ||
|
||
Zotero is distributed in the hope that it will be useful, | ||
but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
GNU Affero General Public License for more details. | ||
|
||
You should have received a copy of the GNU Affero General Public License | ||
along with Zotero. If not, see <http://www.gnu.org/licenses/>. | ||
|
||
***** END LICENSE BLOCK ***** | ||
*/ | ||
|
||
|
||
// attr()/text() v2 per https://github.com/zotero/translators/issues/1277 | ||
function attr(docOrElem,selector,attr,index){var elem=index?docOrElem.querySelectorAll(selector).item(index):docOrElem.querySelector(selector);return elem?elem.getAttribute(attr):null;}function text(docOrElem,selector,index){var elem=index?docOrElem.querySelectorAll(selector).item(index):docOrElem.querySelector(selector);return elem?elem.textContent:null;} | ||
|
||
|
||
function detectWeb(doc, url) { | ||
if (url.includes("/article/") { // does not handle /event/ or /media/ pages, which EM alone can handle | ||
if (text(doc,'.issue-name')) { | ||
return "magazineArticle"; | ||
} | ||
else { | ||
return "blogPost"; | ||
} | ||
} else if (getSearchResults(doc, true)) { | ||
return "multiple"; | ||
} | ||
} | ||
|
||
|
||
function scrape(doc, url) { | ||
var translator = Zotero.loadTranslator('web'); | ||
translator.setTranslator('951c027d-74ac-47d4-a107-9c3069ab7b48'); // embedded metadata (EM) | ||
translator.setDocument(doc); | ||
|
||
translator.setHandler('itemDone', function (obj, item) { // corrections to EM | ||
item.publicationTitle = "Frieze"; | ||
item.issue = text(doc,'.issue-name'); | ||
if (item.issue) { | ||
item.itemType = "magazineArticle"; | ||
item.ISSN = "0962-0672"; | ||
item.issue = item.issue.replace('Issue ',''); | ||
} else { | ||
item.itemType = "blogPost"; | ||
} | ||
item.date = text(doc,'.field-name-article-category-date'); | ||
if (item.date) { | ||
item.date = Z.Utilities.strToISO(item.date.replace(/.*-\s(.*)/,"$1")); | ||
} | ||
var authorMetadata = doc.querySelectorAll('.field-name-article-contributor-name a'); | ||
for (let author of authorMetadata) { | ||
item.creators.push(ZU.cleanAuthor(author.text, "author")); | ||
} | ||
item.complete(); | ||
}); | ||
|
||
translator.getTranslatorObject(function(trans) { | ||
trans.doWeb(doc, url); | ||
}); | ||
} | ||
|
||
|
||
function getSearchResults(doc, checkOnly) { | ||
var items = {}; | ||
var found = false; | ||
var rows = doc.querySelectorAll('.field-name-title-field a'); | ||
for (let i=0; i<rows.length; i++) { | ||
let href = rows[i].href; | ||
let title = ZU.trimInternal(rows[i].textContent); | ||
if (!href || !title) continue; | ||
if (/\/(event|media)\//.test(href)) continue; // scrap items that link to /event/ or /media/ pages | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. if what I say above is right, you could then remove this restriction. |
||
if (checkOnly) return true; | ||
found = true; | ||
items[href] = title; | ||
} | ||
return found ? items : false; | ||
} | ||
|
||
|
||
function doWeb(doc, url) { | ||
switch (detectWeb(doc, url)) { | ||
case "multiple": | ||
Zotero.selectItems(getSearchResults(doc, false), function (items) { | ||
if (!items) { | ||
return true; | ||
} | ||
var articles = []; | ||
for (var i in items) { | ||
articles.push(i); | ||
} | ||
ZU.processDocuments(articles, scrape); | ||
}); | ||
break; | ||
case "magazineArticle": | ||
case "blogPost": | ||
scrape(doc, url); | ||
break; | ||
} | ||
} | ||
/** BEGIN TEST CASES **/ | ||
var testCases = [ | ||
{ | ||
"type": "web", | ||
"url": "https://frieze.com/article/africa-venice", | ||
"items": [ | ||
{ | ||
"itemType": "magazineArticle", | ||
"title": "Africa in Venice", | ||
"creators": [ | ||
{ | ||
"firstName": "Sean", | ||
"lastName": "O'Toole", | ||
"creatorType": "author" | ||
} | ||
], | ||
"date": "2013-09-14", | ||
"ISSN": "0962-0672", | ||
"abstractNote": "The 55th Venice Biennale", | ||
"issue": "157", | ||
"language": "en", | ||
"libraryCatalog": "frieze.com", | ||
"publicationTitle": "Frieze", | ||
"url": "https://frieze.com/article/africa-venice", | ||
"attachments": [ | ||
{ | ||
"title": "Snapshot" | ||
} | ||
], | ||
"tags": [], | ||
"notes": [], | ||
"seeAlso": [] | ||
} | ||
] | ||
}, | ||
{ | ||
"type": "web", | ||
"url": "https://frieze.com/search?text_search=%22venice%20biennale%22", | ||
"items": "multiple" | ||
}, | ||
{ | ||
"type": "web", | ||
"url": "https://frieze.com/article/weekend-reading-list-54", | ||
"items": [ | ||
{ | ||
"itemType": "blogPost", | ||
"title": "Weekend Reading List", | ||
"creators": [ | ||
{ | ||
"firstName": "Paul", | ||
"lastName": "Clinton", | ||
"creatorType": "author" | ||
} | ||
], | ||
"date": "2017-03-10", | ||
"abstractNote": "From the Women's Strike to a march that cancels itself out: what to read this weekend", | ||
"blogTitle": "Frieze", | ||
"language": "en", | ||
"url": "https://frieze.com/article/weekend-reading-list-54", | ||
"attachments": [ | ||
{ | ||
"title": "Snapshot" | ||
} | ||
], | ||
"tags": [], | ||
"notes": [], | ||
"seeAlso": [] | ||
} | ||
] | ||
}, | ||
{ | ||
"type": "web", | ||
"url": "https://frieze.com/article/art-world-overwhelmingly-liberal-still-overwhelmingly-middle-class-and-white-why", | ||
"items": [ | ||
{ | ||
"itemType": "blogPost", | ||
"title": "The Art World is Overwhelmingly Liberal But Still Overwhelmingly Middle Class and White – Why?", | ||
"creators": [ | ||
{ | ||
"firstName": "Hettie", | ||
"lastName": "Judah", | ||
"creatorType": "author" | ||
} | ||
], | ||
"date": "2018-07-06", | ||
"abstractNote": "Is the lack of social mobility in the arts due to a self-congratulatory conviction that the sector represents the solution rather than the problem?", | ||
"blogTitle": "Frieze", | ||
"language": "en", | ||
"url": "https://frieze.com/article/art-world-overwhelmingly-liberal-still-overwhelmingly-middle-class-and-white-why", | ||
"attachments": [ | ||
{ | ||
"title": "Snapshot" | ||
} | ||
], | ||
"tags": [], | ||
"notes": [], | ||
"seeAlso": [] | ||
} | ||
] | ||
}, | ||
{ | ||
"type": "web", | ||
"url": "https://frieze.com/", | ||
"items": "multiple" | ||
} | ||
] | ||
/** END TEST CASES **/ |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For those /event and media pages, you should be able to exclude them from the EM fixes you make in scrape, right? That way they'd work correctly when imported as part of search results (currently that'd e.g. all turn them into blogposts)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The event/media pages are basically listings, so I didn't think anyone would want to cite them like we wouldn't handle classified ads in a newspaper (hence why I excluded them from the multis)
Let me know if you'd still want them