Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove framework checkbox and automatically add attr()/text() #43

Closed
dstillman opened this issue Sep 25, 2017 · 2 comments
Closed

Remove framework checkbox and automatically add attr()/text() #43

dstillman opened this issue Sep 25, 2017 · 2 comments

Comments

@dstillman
Copy link
Member

Part of zotero/translators#1277

We could have a checkbox for attr()/text(), but since they'll be available in the sandbox in future 5.0 versions, we could probably just scan for those functions and insert them if they're used.
This was referenced Sep 25, 2017
Closed
Closed
@zuphilip
Copy link
Collaborator

Would it still be possible to maintain the FW translators afterwards? At least for a short time because it might take time to rewrite all these translators...

@dstillman
Copy link
Member Author

Yeah, if we take out the checkbox, Scaffold just wouldn't know anything about that code block and would leave it in place.

@zuphilip zuphilip mentioned this issue Sep 26, 2017
Merged
zuphilip added a commit to zuphilip/scaffold that referenced this issue Jan 3, 2018
@zuphilip
Delete folder external/zotero-transfw
d4d555f 
It seems that this step was missing from zotero#45.

This completes zotero#43.
@zuphilip zuphilip mentioned this issue Jan 3, 2018
Merged
@zuphilip zuphilip closed this as completed Jan 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dstillman @zuphilip