-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
phpunit tests converted to mocha/chai #140
Open
abaevbog
wants to merge
33
commits into
zotero:master
Choose a base branch
from
abaevbog:mocha-chai-tests
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
cfc8228
phpunit test v1 and v2 converted to mocha/chai
abaevbog d58206e
helper functions for api v3, annotation, atom and creator tests for v3
abaevbog 0244f16
v3 collection, group, fullText and note test
abaevbog f4dfc10
v3 object test
abaevbog b30737f
leftover object tests, mappings, params tests
abaevbog aae33b1
previously skipped tests requiring citation or translation server
abaevbog 878afef
file tests v2 and half of v3
abaevbog e8449db
the rest of file tests
abaevbog 8b7804b
publication tests
abaevbog bf083e1
minor adjustments to prevent random 500 errors
abaevbog 6af7367
more v3 tests
abaevbog 9e746e0
removing work dir, removed unneeded data/ files
abaevbog 339d923
notification, tag and version tests
abaevbog 2f5ccd0
v3 itemTest
abaevbog 755e133
some cleanup, proper retry logic when socket hangs
abaevbog 319ce22
using node-config
abaevbog 1ee44b1
removed inheritance from between api files and helpers
abaevbog 41d5981
package.json
abaevbog 4d7632c
changed 'Setup' for 'Before' and 'Wrapup' for 'After' in shared.js, g…
abaevbog e150cd1
removing retries, using 0-second delay instead
abaevbog ae270e5
minor cleanup, added missing comments, some tweaking with socker hanging
abaevbog 0d653ed
using helper functions for statusForObject + removed unnecessary part…
abaevbog 5e21351
initial pdf text extraction setup
abaevbog 8e0936b
pdf text extraction test
abaevbog 1976445
full-text tests with indexing function invoked locally
abaevbog d8f3427
items/unfiled and items/unfiled/tags tests
abaevbog 2e7a853
?sort=editBy for group libraries
abaevbog d4465f2
test to rename tag for PR #150
abaevbog e7518c2
test for literal || escaping for tags PR #143
abaevbog c5b1a93
new annotation types test
abaevbog 640caf4
minor cleanup, skip tests for PRs, missing tests
abaevbog 8253f4d
skip annotation tags test for collections
abaevbog b2b562a
should_add_zero_integer_value_for_lastPageIndex
abaevbog File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| <p>&nbsp;</p> | ||
| <p style="margin-top: 0.18cm; margin-bottom: 0.18cm; line-height: 100%;" lang="es-ES"><br /><br /></p> | ||
| <p style="margin-top: 0.18cm; margin-bottom: 0.18cm; line-height: 100%;" lang="es-ES"><br /><br /></p> | ||
| <table border="1" cellspacing="0" cellpadding="7" width="614"> | ||
| <colgroup><col width="598"></col> </colgroup> | ||
| <p style="margin-top: 0.18cm; margin-bottom: 0.18cm;" lang="en-US"><span style="font-family: Times New Roman,serif;"><span style="font-size: x-large;"><strong>test</strong></span></span></p> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,123 @@ | ||
| <?xml version="1.0"?> | ||
| <response version="9" timestamp="" userID="23848" defaultLibraryID="21999" updateKey="" earliest=""> | ||
| <updated> | ||
| <creators> | ||
| <creator key="DMAHQQR9" dateAdded="2009-03-07 04:59:21" dateModified="2009-03-07 04:59:23"> | ||
| <firstName>Døn</firstName> | ||
| <lastName>Stîllmån</lastName> | ||
| </creator> | ||
| <creator key="I2QFIFDT" dateAdded="2009-03-07 04:54:17" dateModified="2009-03-07 04:54:17"> | ||
| <name>汉字</name> | ||
| <fieldMode>1</fieldMode> | ||
| </creator> | ||
| <creator key="V9MECAGR" dateAdded="2009-03-07 04:53:27" dateModified="2009-03-07 04:53:28"> | ||
| <firstName>Test</firstName> | ||
| <lastName>Testerman</lastName> | ||
| </creator> | ||
| <creator key="WTEG7VPJ" dateAdded="2009-03-07 04:53:37" dateModified="2009-03-07 04:53:40"> | ||
| <name>Testish McTester</name> | ||
| <fieldMode>1</fieldMode> | ||
| </creator> | ||
| <creator key="ZT4UDTTT" dateAdded="2009-03-07 04:54:37" dateModified="2009-03-07 04:54:42"> | ||
| <firstName>Testy</firstName> | ||
| <lastName>Teststein</lastName> | ||
| </creator> | ||
| </creators> | ||
| <items> | ||
| <item key="2TGWDASM" itemType="note" dateAdded="2009-03-07 04:55:36" dateModified="2009-03-07 04:55:46" sourceItem="DUQPU87V"> | ||
| <note><p>Here's a <strong>child</strong> note.</p></note> | ||
| </item> | ||
| <item key="6TKKAABJ" itemType="bookSection" dateAdded="2009-03-07 04:53:20" dateModified="2009-03-07 04:54:09"> | ||
| <field name="edition">3</field> | ||
| <field name="date">March 6, 2007</field> | ||
| <field name="title">My Book Section</field> | ||
| <creator key="V9MECAGR" creatorType="author" index="0"/> | ||
| <creator key="WTEG7VPJ" creatorType="editor" index="1"/> | ||
| <related>DUQPU87V</related> | ||
| </item> | ||
| <item key="7IMJZ8V6" itemType="attachment" dateAdded="2009-03-07 05:00:17" dateModified="2009-03-07 05:00:42" linkMode="2" mimeType="text/html" charset="utf-8"> | ||
| <field name="title">amazon.html</field> | ||
| <path>AAAAAAFkAAIAAAxNYWNpbnRvc2ggSEQAAAAAAAAAAAAAAAAAAADC/J9aSCsAAAAOrpkLYW1hem9uLmh0bWwAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAADnT/bcS9TKEAAAAAAAAAAP////8AAAkgAAAAAAAAAAAAAAAAAAAAB0Rlc2t0b3AAABAACAAAwvzXmgAAABEACAAAxL2E4QAAAAEADAAOrpkADjPnAA4z5QACACpNYWNpbnRvc2ggSEQ6VXNlcnM6ZGFuOkRlc2t0b3A6YW1hem9uLmh0bWwADgAYAAsAYQBtAGEAegBvAG4ALgBoAHQAbQBsAA8AGgAMAE0AYQBjAGkAbgB0AG8AcwBoACAASABEABIAHVVzZXJzL2Rhbi9EZXNrdG9wL2FtYXpvbi5odG1sAAATAAEvAAAVAAIACv//AAA=</path> | ||
| <note><p>Note on a top-level linked file</p></note> | ||
| <related>DUQPU87V</related> | ||
| </item> | ||
| <item key="976Q6TWE" itemType="attachment" dateAdded="2009-03-07 04:55:59" dateModified="2009-03-07 04:56:16" sourceItem="DUQPU87V" linkMode="1" mimeType="text/html" charset="utf-8"> | ||
| <field name="url">http://chnm.gmu.edu/</field> | ||
| <field name="accessDate">2009-03-07 04:55:59</field> | ||
| <field name="title">Center for History and New Media</field> | ||
| <path>storage:chnm.gmu.edu.html</path> | ||
| <note><p>This is a note for a snapshot.</p></note> | ||
| </item> | ||
| <item key="9P9UVFK3" itemType="note" dateAdded="2009-03-07 04:56:20" dateModified="2009-03-07 04:56:29"> | ||
| <note><p>Here's a top-level note.</p></note> | ||
| </item> | ||
| <item key="C2W49E6Q" itemType="attachment" dateAdded="2009-03-07 04:56:47" dateModified="2009-03-07 04:56:47" linkMode="1" mimeType="text/html" charset="utf-8"> | ||
| <field name="url">http://www.zotero.org/</field> | ||
| <field name="accessDate">2009-03-07 04:56:47</field> | ||
| <field name="title">Zotero: The Next-Generation Research Tool</field> | ||
| <path>storage:www.zotero.org.html</path> | ||
| </item> | ||
| <item key="DUQPU87V" itemType="book" dateAdded="2009-03-07 04:52:56" dateModified="2009-03-07 04:55:18"> | ||
| <field name="title">My Book</field> | ||
| <creator key="I2QFIFDT" creatorType="translator" index="0"/> | ||
| <creator key="ZT4UDTTT" creatorType="author" index="1"/> | ||
| <related>6TKKAABJ 7IMJZ8V6</related> | ||
| </item> | ||
| <item key="G3PTXNXS" itemType="attachment" dateAdded="2009-03-07 04:56:01" dateModified="2009-03-07 04:56:10" sourceItem="DUQPU87V" linkMode="3" mimeType="text/html" charset="utf-8"> | ||
| <field name="url">http://chnm.gmu.edu/</field> | ||
| <field name="accessDate">2009-03-07 04:56:01</field> | ||
| <field name="title">Center for History and New Media</field> | ||
| <note><p>This is a note for a link.</p></note> | ||
| </item> | ||
| <item key="HTHD884W" itemType="attachment" dateAdded="2009-03-07 04:58:37" dateModified="2009-03-07 04:58:37" linkMode="0" mimeType="image/jpeg"> | ||
| <field name="title">FILE.jpg</field> | ||
| <path>storage:FILE.jpg</path> | ||
| </item> | ||
| <item key="T3K4BNWP" itemType="book" dateAdded="2009-03-07 04:59:04" dateModified="2009-03-07 04:59:39" deleted="1"> | ||
| <field name="title">Trashed item</field> | ||
| <creator key="DMAHQQR9" creatorType="author" index="0"/> | ||
| </item> | ||
| </items> | ||
| <collections> | ||
| <collection key="8VE7W6RN" name="Subcollection" dateAdded="2009-03-07 04:57:19" dateModified="2009-03-07 04:57:25" parent="KBTFHUZD"> | ||
| <items>DUQPU87V</items> | ||
| </collection> | ||
| <collection key="9Z7WTWC2" name="Another subcollection" dateAdded="2009-03-07 04:57:53" dateModified="2009-03-07 04:58:38" parent="8VE7W6RN"> | ||
| <items>HTHD884W</items> | ||
| </collection> | ||
| <collection key="KBTFHUZD" name="My Collection" dateAdded="2009-03-07 04:55:26" dateModified="2009-03-07 04:56:01"> | ||
| <items>6TKKAABJ 9P9UVFK3</items> | ||
| </collection> | ||
| <collection key="M6B882D5" name="Empty subcollection" dateAdded="2009-03-07 04:57:36" dateModified="2009-03-07 04:57:36" parent="8VE7W6RN"/> | ||
| </collections> | ||
| <searches> | ||
| <search key="W2KN2TFW" name="Me" dateAdded="2009-03-07 04:57:10" dateModified="2009-03-07 04:57:10"> | ||
| <condition id="1" condition="title" operator="contains" value="My"/> | ||
| <condition id="2" condition="edition" operator="is" value="2"/> | ||
| </search> | ||
| <search key="Q88FDVN3" name="Notes" dateAdded="2009-03-07 05:01:14" dateModified="2009-03-07 05:01:14"> | ||
| <condition id="1" condition="itemTypeID" operator="is" value="1"/> | ||
| </search> | ||
| </searches> | ||
| <tags> | ||
| <tag key="MR3BTEPM" name="Birds" dateAdded="2009-03-07 04:55:05" dateModified="2009-03-07 04:55:05"> | ||
| <items>6TKKAABJ</items> | ||
| </tag> | ||
| <tag key="TNT9H7Q2" name="Cats" dateAdded="2009-03-07 04:55:02" dateModified="2009-03-07 04:55:02"> | ||
| <items>6TKKAABJ</items> | ||
| </tag> | ||
| <tag key="4EQG6EUX" name="Dogs" dateAdded="2009-03-07 04:54:54" dateModified="2009-03-07 04:55:04"> | ||
| <items>6TKKAABJ DUQPU87V</items> | ||
| </tag> | ||
| <tag key="IPSDQFTW" name="Fish" dateAdded="2009-03-07 04:54:56" dateModified="2009-03-07 04:54:56"> | ||
| <items>DUQPU87V</items> | ||
| </tag> | ||
| <tag key="EAMSZGIN" name="Frogs" dateAdded="2009-03-07 04:58:47" dateModified="2009-03-07 04:58:47"> | ||
| <items>HTHD884W</items> | ||
| </tag> | ||
| <tag key="QU5QF6A7" name="Kumquats" dateAdded="2009-03-07 04:59:33" dateModified="2009-03-07 04:59:33"> | ||
| <items>T3K4BNWP</items> | ||
| </tag> | ||
| </tags> | ||
| </updated> | ||
| </response> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,120 @@ | ||
| <data version="9"> | ||
| <creators> | ||
| <creator libraryID="" dateAdded="2009-03-07 04:53:27" dateModified="2009-03-07 04:53:28" key="V9MECAGR"> | ||
| <firstName>Test</firstName> | ||
| <lastName>Testerman</lastName> | ||
| </creator> | ||
| <creator libraryID="" dateAdded="2009-03-07 04:54:17" dateModified="2009-03-07 04:54:17" key="I2QFIFDT"> | ||
| <name>汉字</name> | ||
| <fieldMode>1</fieldMode> | ||
| </creator> | ||
| <creator libraryID="" dateAdded="2009-03-07 04:54:37" dateModified="2009-03-07 04:54:42" key="ZT4UDTTT"> | ||
| <firstName>Testy</firstName> | ||
| <lastName>Teststein</lastName> | ||
| </creator> | ||
| <creator libraryID="" dateAdded="2009-03-07 04:59:21" dateModified="2009-03-07 04:59:23" key="DMAHQQR9"> | ||
| <firstName>Døn</firstName> | ||
| <lastName>Stîllmån</lastName> | ||
| </creator> | ||
| </creators> | ||
| <items> | ||
| <item libraryID="" itemType="bookSection" dateAdded="2009-03-07 04:53:20" dateModified="2009-03-07 04:54:09" key="6TKKAABJ"> | ||
| <field name="edition">3</field> | ||
| <field name="date">2007-03-06 March 6, 2007</field> | ||
| <field name="title">My Book Section</field> | ||
| <creator key="V9MECAGR" creatorType="author" index="0"/> | ||
| <creator key="WTEG7VPJ" creatorType="editor" index="1"> | ||
| <creator libraryID="" dateAdded="2009-03-07 04:53:37" dateModified="2009-03-07 04:53:40" key="WTEG7VPJ"> | ||
| <name>Testish McTester</name> | ||
| <fieldMode>1</fieldMode> | ||
| </creator> | ||
| </creator> | ||
| </item> | ||
| <item libraryID="" itemType="book" dateAdded="2009-03-07 04:52:56" dateModified="2009-03-07 04:55:18" key="DUQPU87V"> | ||
| <field name="title">My Book</field> | ||
| <creator key="I2QFIFDT" creatorType="translator" index="0"/> | ||
| <creator key="ZT4UDTTT" creatorType="author" index="1"/> | ||
| <related>6TKKAABJ</related> | ||
| </item> | ||
| <item libraryID="" itemType="note" dateAdded="2009-03-07 04:55:36" dateModified="2009-03-07 04:55:46" key="2TGWDASM" sourceItem="DUQPU87V"> | ||
| <note><p>Here's a <strong>child</strong> note.</p></note> | ||
| </item> | ||
| <item libraryID="" itemType="attachment" dateAdded="2009-03-07 04:56:01" dateModified="2009-03-07 04:56:10" key="G3PTXNXS" sourceItem="DUQPU87V" linkMode="3" mimeType="text/html" charset="utf-8"> | ||
| <field name="url">http://chnm.gmu.edu/</field> | ||
| <field name="accessDate">2009-03-07 04:56:01</field> | ||
| <field name="title">Center for History and New Media</field> | ||
| <note><p>This is a note for a link.</p></note> | ||
| </item> | ||
| <item libraryID="" itemType="attachment" dateAdded="2009-03-07 04:55:59" dateModified="2009-03-07 04:56:16" key="976Q6TWE" sourceItem="DUQPU87V" linkMode="1" mimeType="text/html" charset="utf-8"> | ||
| <field name="url">http://chnm.gmu.edu/</field> | ||
| <field name="accessDate">2009-03-07 04:55:59</field> | ||
| <field name="title">Center for History and New Media</field> | ||
| <path>storage:chnm.gmu.edu.html</path> | ||
| <note><p>This is a note for a snapshot.</p></note> | ||
| </item> | ||
| <item libraryID="" itemType="note" dateAdded="2009-03-07 04:56:20" dateModified="2009-03-07 04:56:29" key="9P9UVFK3"> | ||
| <note><p>Here's a top-level note.</p></note> | ||
| </item> | ||
| <item libraryID="" itemType="attachment" dateAdded="2009-03-07 04:56:47" dateModified="2009-03-07 04:56:47" key="C2W49E6Q" linkMode="1" mimeType="text/html" charset="utf-8"> | ||
| <field name="url">http://www.zotero.org/</field> | ||
| <field name="accessDate">2009-03-07 04:56:47</field> | ||
| <field name="title">Zotero: The Next-Generation Research Tool</field> | ||
| <path>storage:www.zotero.org.html</path> | ||
| </item> | ||
| <item libraryID="" itemType="attachment" dateAdded="2009-03-07 04:58:37" dateModified="2009-03-07 04:58:37" key="HTHD884W" linkMode="0" mimeType="image/jpeg"> | ||
| <field name="title">FILE.jpg</field> | ||
| <path>storage:FILE.jpg</path> | ||
| </item> | ||
| <item libraryID="" itemType="book" dateAdded="2009-03-07 04:59:04" dateModified="2009-03-07 04:59:39" key="T3K4BNWP" deleted="1"> | ||
| <field name="title">Trashed item</field> | ||
| <creator key="DMAHQQR9" creatorType="author" index="0"/> | ||
| </item> | ||
| <item libraryID="" itemType="attachment" dateAdded="2009-03-07 05:00:17" dateModified="2009-03-07 05:00:42" key="7IMJZ8V6" linkMode="2" mimeType="text/html" charset="utf-8"> | ||
| <field name="title">amazon.html</field> | ||
| <path>AAAAAAFkAAIAAAxNYWNpbnRvc2ggSEQAAAAAAAAAAAAAAAAAAADC/J9aSCsAAAAOrpkLYW1hem9uLmh0bWwAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAADnT/bcS9TKEAAAAAAAAAAP////8AAAkgAAAAAAAAAAAAAAAAAAAAB0Rlc2t0b3AAABAACAAAwvzXmgAAABEACAAAxL2E4QAAAAEADAAOrpkADjPnAA4z5QACACpNYWNpbnRvc2ggSEQ6VXNlcnM6ZGFuOkRlc2t0b3A6YW1hem9uLmh0bWwADgAYAAsAYQBtAGEAegBvAG4ALgBoAHQAbQBsAA8AGgAMAE0AYQBjAGkAbgB0AG8AcwBoACAASABEABIAHVVzZXJzL2Rhbi9EZXNrdG9wL2FtYXpvbi5odG1sAAATAAEvAAAVAAIACv//AAA=</path> | ||
| <note><p>Note on a top-level linked file</p></note> | ||
| <related>DUQPU87V</related> | ||
| </item> | ||
| </items> | ||
| <collections> | ||
| <collection libraryID="" name="My Collection" dateAdded="2009-03-07 04:55:26" dateModified="2009-03-07 04:56:01" key="KBTFHUZD"> | ||
| <items>6TKKAABJ 9P9UVFK3</items> | ||
| </collection> | ||
| <collection libraryID="" name="Subcollection" dateAdded="2009-03-07 04:57:19" dateModified="2009-03-07 04:57:25" key="8VE7W6RN" parent="KBTFHUZD"> | ||
| <items>DUQPU87V</items> | ||
| </collection> | ||
| <collection libraryID="" name="Empty subcollection" dateAdded="2009-03-07 04:57:36" dateModified="2009-03-07 04:57:36" key="M6B882D5" parent="8VE7W6RN"/> | ||
| <collection libraryID="" name="Another subcollection" dateAdded="2009-03-07 04:57:53" dateModified="2009-03-07 04:58:38" key="9Z7WTWC2" parent="8VE7W6RN"> | ||
| <items>HTHD884W</items> | ||
| </collection> | ||
| </collections> | ||
| <searches> | ||
| <search libraryID="" name="Me" dateAdded="2009-03-07 04:57:10" dateModified="2009-03-07 04:57:10" key="W2KN2TFW"> | ||
| <condition id="1" condition="title" operator="contains" value="My"/> | ||
| <condition id="2" condition="edition" operator="is" value="2"/> | ||
| </search> | ||
| <search libraryID="" name="Notes" dateAdded="2009-03-07 05:01:14" dateModified="2009-03-07 05:01:14" key="Q88FDVN3"> | ||
| <condition id="1" condition="itemTypeID" operator="is" value="1"/> | ||
| </search> | ||
| </searches> | ||
| <tags> | ||
| <tag libraryID="" name="Fish" dateAdded="2009-03-07 04:54:56" dateModified="2009-03-07 04:54:56" key="IPSDQFTW"> | ||
| <items>DUQPU87V</items> | ||
| </tag> | ||
| <tag libraryID="" name="Cats" dateAdded="2009-03-07 04:55:02" dateModified="2009-03-07 04:55:02" key="TNT9H7Q2"> | ||
| <items>6TKKAABJ</items> | ||
| </tag> | ||
| <tag libraryID="" name="Dogs" dateAdded="2009-03-07 04:54:54" dateModified="2009-03-07 04:55:04" key="4EQG6EUX"> | ||
| <items>6TKKAABJ DUQPU87V</items> | ||
| </tag> | ||
| <tag libraryID="" name="Birds" dateAdded="2009-03-07 04:55:05" dateModified="2009-03-07 04:55:05" key="MR3BTEPM"> | ||
| <items>6TKKAABJ</items> | ||
| </tag> | ||
| <tag libraryID="" name="Frogs" dateAdded="2009-03-07 04:58:47" dateModified="2009-03-07 04:58:47" key="EAMSZGIN"> | ||
| <items>HTHD884W</items> | ||
| </tag> | ||
| <tag libraryID="" name="Kumquats" dateAdded="2009-03-07 04:59:33" dateModified="2009-03-07 04:59:33" key="QU5QF6A7"> | ||
| <items>T3K4BNWP</items> | ||
| </tag> | ||
| </tags> | ||
| </data> |
Binary file not shown.
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sync1download.xml and sync2upload.xml can be removed. These were from the old sync system.