Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add missing languages options #667

Merged
merged 5 commits into from
Nov 10, 2024

Conversation

felipemarinho97
Copy link
Contributor

@felipemarinho97 felipemarinho97 commented Nov 9, 2024

Its 99% transalated but its not listed

@felipemarinho97
Copy link
Contributor Author

Unfortunately, I was not able to test the changes locally due to #668

@zoriya
Copy link
Owner

zoriya commented Nov 10, 2024

wait you're right, a lot of translations are not imported there! that's a huge oversight, we should find a way to include all translations without requiring to edit this file manually.

we could either:

  • import all files in the directory
  • use a remote fetch plugin (this would also allow translations to be updated without an update/release)

@felipemarinho97 felipemarinho97 changed the title chg: feat: add brazillian portuguese to language options Feat: Add missing languages options Nov 10, 2024
@felipemarinho97
Copy link
Contributor Author

@zoriya It doesn't seem like an easy task, for now I've added all languages ​​with translation > 30%. I was able to validate the component as well, without connecting to a backend.
Screenshot 2024-11-10 at 00 51 49

@zoriya zoriya merged commit cee6993 into zoriya:master Nov 10, 2024
12 checks passed
@felipemarinho97 felipemarinho97 deleted the feat/add-pt-br-front branch November 11, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants