Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop the use of the deprecated setuptools Features #67

Merged
merged 1 commit into from
Feb 12, 2020
Merged

Drop the use of the deprecated setuptools Features #67

merged 1 commit into from
Feb 12, 2020

Conversation

jamadden
Copy link
Member

@jamadden jamadden commented Jan 20, 2020 •
edited
Loading

@jamadden jamadden force-pushed the deprecated-setuptools-features branch from 9a3f7d6 to 599821b Compare January 20, 2020 12:46
mgedmin
mgedmin reviewed Jan 20, 2020
View reviewed changes
setup.py
@@ -114,12 +110,11 @@ def __str__(self):

if is_pypy or is_jython:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe please add an or is_pure check with the os.getenv('PURE_PYTHON') logic copied from zope.interface etc.? So people can ask to skip extension modules.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, right, I copy-pasted a few of these before realizing my mistake. It's a bad idea to check PURE_PYTHON during build time because that will poison pip's wheel caches.

@icemac
Copy link
Member

icemac commented Feb 12, 2020

Is there something open before this PR can be merged?

@jamadden
Copy link
Member Author

Waiting on an approval. @mgedmin had some feedback here about checking PURE_PYTHON at build time, but later in zope.interface we actually decided not to do any PURE_PYTHON checks at build time, so that may no longer apply.

(I'd like to bring the PURE_PYTHON logic used in zope.interface over here eventually.)

mgedmin
mgedmin approved these changes Feb 12, 2020
View reviewed changes
Copy link
Member

@mgedmin mgedmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I guess? I've never used setuptool features so I don't know what the consequences will be. I'm cautiously optimistic.

@jamadden
Copy link
Member Author

I'm cautiously optimistic.

Me too! Thanks!

@jamadden jamadden merged commit a700e2e into master Feb 12, 2020
@jamadden jamadden deleted the deprecated-setuptools-features branch February 12, 2020 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgedmin mgedmin mgedmin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jamadden @icemac @mgedmin