Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to coveralls 3.0 #100

Merged
merged 1 commit into from
Jan 13, 2021
Merged

Update to coveralls 3.0 #100

merged 1 commit into from
Jan 13, 2021

Conversation

icemac
Copy link
Member

@icemac icemac commented Jan 13, 2021

No description provided.

@icemac icemac merged commit 7b93772 into master Jan 13, 2021
@icemac icemac deleted the config-with-pure-python branch January 13, 2021 07:35
@@ -53,6 +53,6 @@ jobs:
if: matrix.config[1] == 'coverage'
run: |
pip install coveralls coverage-python-version
coveralls
coveralls --service=github
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIU this is needed because of TheKevJames/coveralls-python#252: sometimes coverage upload fails with 422 for obscure reasons, nobody understands why, and switching the service name sometimes helps.

And I see we had a failed coverage upload in git master earlier, and this branch fixes that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sometimes helps

Indeed.

offtopic:
If you know another reason why those 422 are happening, please tell me :-/

In this one case it did not help - and I have no clue why. coveralls integration is a obscure thing
https://github.com/morepath/morepath_rest_dump_load/pull/9/checks?check_run_id=1690078143
https://github.com/morepath/morepath_rest_dump_load/blob/master/.github/workflows/main.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants