Drop the use of the deprecated setuptools Features #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgedmin
reviewed
Jan 20, 2020
| } | ||
|
|
||
| ext_modules = [] | ||
| if not is_pypy and not is_jython: |
There was a problem hiding this comment.
Maybe please add an and not is_pure check with the os.getenv('PURE_PYTHON') logic copied from zope.interface etc.? So people can ask to skip extension modules.
There was a problem hiding this comment.
You know what, you're right and I was wrong. Build-time checking of PURE_PYTHON will poison pip's wheel cache and we should fix zope.interface not to do that.
There was a problem hiding this comment.
I was slightly surprised to discover that you get different wheel file names depending on whether PURE_PYTHON is set (zope.interface-4.7.2.dev0-py3-none-any.whl) or not (zope.interface-4.7.2.dev0-cp38-cp38-macosx_10_15_x86_64.whl). I suspect it still messes with the cache though.
jamadden
force-pushed
the
deprecated-setuptools-features
branch
from
985b5ee to
3c0f7dc
Compare
Don't install nose, upstream no longer supports. We were actually testing with zope.testrunner on travis and in tox.ini so use that. make appveyor do the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pypa/setuptools#65