Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PyPy/Pure-Python: PickleCache.new_ghost destroys any information passed to __new__ #49

Closed
jamadden opened this issue Oct 28, 2016 · 2 comments
Closed

PyPy/Pure-Python: PickleCache.new_ghost destroys any information passed to __new__ #49

jamadden opened this issue Oct 28, 2016 · 2 comments

Comments

@jamadden
Copy link
Member

Spurred from the work in #44, with a lengthy description in #44 (comment)

Both dicts and slots are affected and need a test case.
@jamadden
Copy link
Member Author

Avoiding clearing the dict/slots in new_ghost fixes the problems for zope.container and doesn't break anything in ZODB tests.

It shouldn't be too hard to add some tests and work up a PR.

jamadden added a commit that referenced this issue Oct 28, 2016
@jamadden
Don't clear the slots/dict when adding a new_ghost to Python
7fb761e 
PickleCache.

Fixes #49.

Unfortunately, this doesn't fix the whole problem, because
_p_deactivate() still clears them, and so we lose what we set in __new__.
@jamadden
Copy link
Member Author

Unfortunately, this doesn't seem to be fully fixable. Moving discussion back over to #44 since that was the source of the problem.

@jamadden jamadden mentioned this issue Oct 28, 2016
Merged
jamadden added a commit that referenced this issue Dec 19, 2016
@jamadden
Don't clear the slots/dict when adding a new_ghost to Python
de9f3f2 
PickleCache.

Fixes #49.

Unfortunately, this doesn't fix the whole problem, because
_p_deactivate() still clears them, and so we lose what we set in __new__.
@jamadden jamadden mentioned this issue Dec 19, 2016
Merged
jamadden added a commit that referenced this issue Dec 19, 2016
@jamadden
Don't clear the slots/dict when adding a new_ghost to Python
d03760b 
PickleCache.

Fixes #49.

Unfortunately, this doesn't fix the whole problem, because
_p_deactivate() still clears them, and so we lose what we set in __new__.
fabiomaggio pushed a commit to fabiomaggio/persistent that referenced this issue Feb 20, 2017
@jamadden
Don't clear the slots/dict when adding a new_ghost to Python
7b7f53a 
PickleCache.

Fixes zopefoundation#49.

Unfortunately, this doesn't fix the whole problem, because
_p_deactivate() still clears them, and so we lose what we set in __new__.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jamadden