Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building Linux wheels seems to be broken #113

Closed
icemac opened this issue May 9, 2019 · 3 comments · Fixed by #119
Closed

Building Linux wheels seems to be broken #113

icemac opened this issue May 9, 2019 · 3 comments · Fixed by #119

Comments

@icemac
Copy link
Member

icemac commented May 9, 2019

See https://travis-ci.org/zopefoundation/persistent/builds/530228105

@jamadden
Copy link
Member

jamadden commented May 9, 2019

Yeah, I've seen that before. IIRC the version of auditwheel is tightly tied to wheel and you can't upgrade wheel in the docker image without having this issue.

We should perhaps move on to the manylinux2010 image anyway (which still has this issue, but at least has a newer compiler). It will still generate manylinux1 tagged wheels if possible.

@mgedmin
Copy link
Member

mgedmin commented May 9, 2019

This looks like pypa/auditwheel#102, filed in 2018, so how come we haven't seen this problem before now?

@jamadden
Copy link
Member

jamadden commented May 9, 2019

The release of persistent 4.4.2 from August 2018 has manylinux wheels; the release of persistent 4.4.3 from the end of October 2018 (after the release of wheel which broke auditwheel) does not. So we have had the problem before, we just didn't notice.

mgedmin added a commit that referenced this issue Nov 6, 2019
Should fix #113.

We can't see if the fix works because wheels are built only for git
tags.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants