Support for specifying a minimum supported Python version #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-maurer
approved these changes
Oct 3, 2024
|
Jens Vagelpohl wrote at 2024-10-2 23:33 -0700:
@dataflake commented on this pull request.
> @@ -348,7 +371,7 @@ def pre_commit_config_yaml(self):
"pre-commit-config.yaml.j2",
self.path / ".pre-commit-config.yaml",
self.config_type,
- oldest_python_version=OLDEST_PYTHON_VERSION.replace(".", ""),
+ oldest_python_version=self.oldest_python.replace(".", ""),
I don't understand this comment. This line removes dots. It will work the same with a version number `10.5` as it does with `3.8`. Or am I misunderstanding something?
Removing the dots will lose information: `3.12` and `31.2`
are mapped to the same `312`.
|
Sorry Dieter, that is a bridge we can worry about when Python 10 arrives. Both of us may no longer be around. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for a new command line parameter
--oldest-pythonand a corresponding value in.meta.tomlthat allows setting a minimum supported Python version that may be different from the previously hardcoded default.