Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Specify FUTURE_PYTHON_VERSION as version range" #219

Closed
wants to merge 2 commits into from

Conversation

icemac
Copy link
Member

@icemac icemac commented Oct 16, 2023

Reverts #218

Until there is a Python 3.13 alpha version at GHA the changes break running config-package.py if with-future-python is true. I think the merge was done too early.

We can revert this revert when the 3.13 alpha finally appears.

Needed for zopefoundation/zope.index#45

@dataflake
Copy link
Member

I disagree. From all I can tell all that breaks is that tox and GHA cannot find the interpreter. Instead of reverting the change in this package it is easy to just switch the future python flag in the affected packages' .meta.toml and run the configure script again. You will have to re-run the configuration script again, anyway, no matter where you make the change.

@dataflake
Copy link
Member

I'll look at this again today.

@icemac
Copy link
Member Author

icemac commented Oct 17, 2023

In python/pythoncapi-compat#79 I learned that 3.13 as version specifier seems to be enough. According to https://github.com/python/pythoncapi-compat/actions/runs/6533893659/job/17739970573 a 3.13a1 version is already available.

It seems we can close this issue and replace the version specifier by 3.13 for future releases.

@dataflake
Copy link
Member

I can try that out later today.

@icemac
Copy link
Member Author

icemac commented Oct 17, 2023

zopefoundation/DocumentTemplate#73 shows that the version range you proposed also works.

@dataflake
Copy link
Member

https://github.com/zopefoundation/DocumentTemplate/actions/runs/6545745015/job/17774852634 proves that a simple "3.13" doesn't consider prereleases, the range as proposed is still the better solution.

Copy link
Member

@dataflake dataflake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there is a 3.13 prerelease now I put the range specification back in.

@icemac
Copy link
Member Author

icemac commented Oct 20, 2023

As there is now an alpha release, this PR is no longer necessary.

@icemac icemac closed this Oct 20, 2023
@icemac icemac deleted the revert-218-dataflake/future_python_range branch October 20, 2023 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants