-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not break when indexing multiple indexes #89
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dataflake
approved these changes
Dec 5, 2019
jugmac00
reviewed
Dec 6, 2019
jugmac00
reviewed
Dec 6, 2019
@@ -410,14 +410,12 @@ def manage_clearIndex(self, ids=None, | |||
|
|||
@security.protected(manage_zcatalog_entries) | |||
def reindexIndex(self, name, REQUEST, pghandler=None): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to see a docstring added, as it is not entirely clear what name is, or should be. Obviously it can be a string or something else.
Jürgen Gmach wrote at 2019-12-5 23:24 -0800:
jugmac00 commented on this pull request.
> @@ -410,14 +410,12 @@ def manage_clearIndex(self, ids=None,
@security.protected(manage_zcatalog_entries)
def reindexIndex(self, name, REQUEST, pghandler=None):
I'd like to see a docstring added, as it is not entirely clear what name is, or should be. Obviously it can be a string or something else.
Note that a "docstring" has as side effect that the object
becames "Web publishable" (i.e. can be directly called via the Web).
Reindexing can take a long time; therefore, it might be interesting
to quite tightly control its use.
|
@d-maurer Thank you for the hint. I know why I am a big fan of "explicit is better than implicit" :-) |
Maybe it's time for type annotations 😛
jugmac00
reviewed
Dec 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to reindex multiple indexes while having a progress handler it was breaking before with: