Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not break when indexing multiple indexes #89

Merged
merged 6 commits into from
Dec 6, 2019
Merged

Conversation

icemac
Copy link
Member

@icemac icemac commented Dec 5, 2019

When trying to reindex multiple indexes while having a progress handler it was breaking before with:

...
  File ".../Products.ZCatalog-5.0.1-py3.7.egg/Products/ZCatalog/ZCatalog.py", line 420, in reindexIndex
    pghandler.init('reindexing %s' % name, len(paths))
TypeError: not all arguments converted during string formatting

@icemac icemac self-assigned this Dec 5, 2019
@icemac icemac marked this pull request as ready for review December 5, 2019 15:54
@icemac icemac requested a review from dataflake December 5, 2019 15:54
CHANGES.rst Show resolved Hide resolved
@@ -410,14 +410,12 @@ def manage_clearIndex(self, ids=None,

@security.protected(manage_zcatalog_entries)
def reindexIndex(self, name, REQUEST, pghandler=None):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to see a docstring added, as it is not entirely clear what name is, or should be. Obviously it can be a string or something else.

@d-maurer
Copy link
Contributor

d-maurer commented Dec 6, 2019 via email

@jugmac00
Copy link
Member

jugmac00 commented Dec 6, 2019

@d-maurer Thank you for the hint. I know why I am a big fan of "explicit is better than implicit" :-)

Michael Howitz added 3 commits December 6, 2019 13:44
@icemac icemac merged commit 4a9ccec into master Dec 6, 2019
@icemac icemac deleted the icemac-patch-1 branch December 6, 2019 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants