Add classifications counters for classrooms and students. #101
Conversation
Add table for student list. Add FontAwesome CDN. Add Spinner component. Some styling and tidying up.
|
@eatyourgreens or @shaunanoordin this is ready for review :) |
| <tr key={i}> | ||
| <td>{attributes.zooniverse_display_name}</td> | ||
| <td>{attributes.classifications_count}</td> | ||
| <td className="btn btn-warning" role="button">Remove</td> |
There was a problem hiding this comment.
Table cells aren't clickable or focusable elements, so better to use a <button> element inside the table cell here.
|
Overall, the code looks good to me! That said, Jim raises a good point re: s and s, so I'll wait until that's addressed before merging.
Tested on Chrome49/FF45/Safari9 on MacbookPro+OSX Note: There were some issues loading classes on FF, but they happened only a few times and I haven't had any success replicating them consistently, so that may just be an issue with me. Status: Pending - happy to merge after td/button issue is addressed. |
|
@shaunanoordin I've included the comments, thanks. |
Fixes #96.
|
Sweet! I also see that Groups are now called Assignments. Status: LGTM |
Add classifications counters for classrooms and students.
Also: