Build with Node 18 #105
Merged
Build with Node 18 #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eatyourgreens
force-pushed
the
node-18
branch
7 times, most recently
from
3218f9d to
4ddc810
Compare
Bump the Dockerfile to Node 18. Only install production dependencies. Bump the package file to Node 18.
eatyourgreens
force-pushed
the
node-18
branch
from
4ddc810 to
6956b58
Compare
eatyourgreens
commented
Feb 13, 2023
| @@ -1,4 +1,7 @@ | |||
| FROM node:14-slim as builder | |||
| FROM node:18-slim as builder | |||
There was a problem hiding this comment.
I think this can be changed to node:18-alpine, to make the image smaller.
eatyourgreens
commented
Feb 13, 2023
Comment on lines
+3
to
+4
| ARG NODE_ENV=production | ||
| ENV NODE_ENV=$NODE_ENV |
There was a problem hiding this comment.
These should ensure that Webpack etc. isn't installed into the deployed image. It will install React and MobX State Tree, which aren't needed by the proxy server, so can probably be improved.
shaunanoordin
approved these changes
Feb 21, 2023
There was a problem hiding this comment.
PR Review
This PR updates the code to build with Node 18 (this mostly affects the Proxy Server), and requires Node 18 to run local development.
- Also,
node-fetchis no longer required! I didn't realise that Node 18 added the Fetch API, but it's very welcome.
Tested by running/testing 1. the web app and 2. the proxy server (example URL).
LGTM 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node-fetch.