Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish update before enqueueing worker #4358

Merged
merged 3 commits into from
Jul 10, 2024
Merged

Finish update before enqueueing worker #4358

merged 3 commits into from
Jul 10, 2024

Conversation

zwolf
Copy link
Member

@zwolf zwolf commented Jul 8, 2024

The AggregationCompletedMailerWorker is sending failure emails for successful runs. Instead of passing a block to super, the AggregationsController should finish the update first so that the resource has its new status saved before enqueueing the mailer. Also, let's assume params are strings in the specs.

Review checklist

  • First, the most important one: is this PR small enough that you can actually review it? Feel free to just reject a branch if the changes are hard to review due to the length of the diff.
  • If there are any migrations, will they the previous version of the app work correctly after they've been run (e.g. the don't remove columns still known about by ActiveRecord).
  • If anything changed with regards to the public API, are those changes also documented in the apiary.apib file?
  • Are all the changes covered by tests? Think about any possible edge cases that might be left untested.

@zwolf zwolf requested review from yuenmichelle1 and Tooyosi July 8, 2024 20:40
@zwolf zwolf merged commit a2c663c into master Jul 10, 2024
8 checks passed
@zwolf zwolf deleted the agg-controller-fix-3 branch July 10, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants