Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explicitly handle error when subject set is empty #3672

Merged
merged 1 commit into from
Sep 16, 2021

Conversation

camallen
Copy link
Contributor

linked to #3450

avoid trying to set NaN values in the DB (0.0 / 0.0), instead raise a custom error which we may ingore longer term via HB via something like

Honeybadger.configure do |config|
  config.exceptions.ignore << SubjectSetCompletenessWorker::EmptySubjectSet
end

Review checklist

  • First, the most important one: is this PR small enough that you can actually review it? Feel free to just reject a branch if the changes are hard to review due to the length of the diff.
  • If there are any migrations, will they the previous version of the app work correctly after they've been run (e.g. the don't remove columns still known about by ActiveRecord).
  • If anything changed with regards to the public API, are those changes also documented in the apiary.apib file?
  • Are all the changes covered by tests? Think about any possible edge cases that might be left untested.

avoid trying to set NaN values in the DB (0.0 / 0.0), instead raise a custom error which we may ingore longer term via HB
@camallen camallen merged commit a2ed05d into master Sep 16, 2021
@camallen camallen deleted the fix-nan-set-completeness-error branch September 16, 2021 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant