do not destroy location relations with invalid location updates #1893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| end | ||
|
|
||
| it 'should create externally linked media resources' do | ||
| update_params[:subjects].merge!(locations: external_locs) |
There was a problem hiding this comment.
Use update_params[:subjects][:locations] = external_locs instead of update_params[:subjects].merge!(locations: external_locs).
camallen
force-pushed
the
subject_update_locations
branch
from
9032b6d to
4ecb8a6
Compare
| if locations_update | ||
| new_locations = add_locations(locations, resource) | ||
| end | ||
| resource.save! |
There was a problem hiding this comment.
actually - think i'll move this to a block for the locations update method.
camallen
force-pushed
the
subject_update_locations
branch
from
4ecb8a6 to
cde8f3a
Compare
| subject.locations.build(location_params) | ||
| new_locations = if locations.blank? | ||
| nil | ||
| else |
camallen
force-pushed
the
subject_update_locations
branch
2 times, most recently
from
4d1a22c to
0f6a8bd
Compare
| subject.locations = add_locations(locations, subject) | ||
| subject.save! | ||
| super(update_params, id) | ||
| add_locations(locations, resource) do |subject| |
There was a problem hiding this comment.
Pass &:save! as an argument to add_locations instead of a block.
run the has_many update after the resource validation has occurred not before
camallen
force-pushed
the
subject_update_locations
branch
from
0f6a8bd to
53cf8a9
Compare
|
thank you hound for barking at me for a simpler solution...much better now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1885 - avoid invalid location updates on the media resource. Make sure these validations pass before updating the relation to reflect the updated location resource.
Describe your change here.
Review checklist
apiary.apibfile?