Add user group ids to classifications #1660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -118,6 +119,10 @@ def add_project_live_state | |||
| update_classification_metadata(:live_project, project.live) | |||
| end | |||
|
|
|||
| def add_user_groups | |||
| update_classification_metadata(:user_group_ids, user.non_identity_user_group_ids) | |||
There was a problem hiding this comment.
I thought the client would supply this info to capture the correct context of the classification. I.e. i was classifying subject X from assignment Y in user_group P..
There was a problem hiding this comment.
Assignments aren't coming until later this year. But because Amy is (going to be) working on a PFE interface for creating / joining groups, I imagine we'll have groups of friends becoming groups, so having the groups for all projects might give neat insights with respect to clusters of users? Doing it in the backend also means we get it for custom frontends for free.
marten
force-pushed
the
add-user-group-ids-to-classifications
branch
from
c74091c to
81c8454
Compare
|
LGTM - just need a spec change to match_array. |
marten
force-pushed
the
add-user-group-ids-to-classifications
branch
from
81c8454 to
f4b9d86
Compare
marten
added a commit
that referenced
this pull request
Feb 10, 2016
…tions Add user group ids to classifications
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is so we can associate classifications with user groups (in post-processing done by education api)