-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rack-timeout using default settings #1265
Conversation
Adds react timeout with a default of 15s to process a request. Also bump gem minor updates lock mysql2 gem minor updates that won't build
updated schema_plus_pg_indexes gem breaks old migration
What kind of error does rack::timeout throw without any |
500's by the looks, we can catch it and return a different error but need to take care that we don't get stuck there...https://github.com/heroku/rack-timeout#errors |
what does the front end do on 500's now? |
Shows |
I had a local branch where I was working on rescuing and returning. I think I got hung up figuring out tests for it. |
Nevermind looks like I don't have it anymore. I don't mind merging this in and figuring out the proper handling later. |
I was just going to say let's get this in and see what happens. I think these stuck threads that would raise the timeout error never return anyway. they get stuck looking for a FUTEX that is never set so the associated client request ends up timing out i assume. |
I see this as a stop gap, if it's causing too many problems we can rip it out and look at another solution. |
Add rack-timeout using default settings
Supersedes #1055
Adds react timeout with a default of 15s to process a request. Also bump gem minor updates lock mysql2 gem minor updates that won't build. Hopefully this will help with the stuck puma thread while we figure out a way to fix it.