Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuth improvements #82

Merged
merged 2 commits into from
Feb 23, 2018
Merged

OAuth improvements #82

merged 2 commits into from
Feb 23, 2018

Conversation

eatyourgreens
Copy link
Contributor

@eatyourgreens eatyourgreens commented Feb 15, 2018

  • Don't clear the saved token before a refresh. We might need to use it before we receive the new token.
  • Return null from the refresh if we can't obtain a token.
  • Call checkBearerToken() on initial load, if no token is present in the URL.

Don't clear the saved token before a refresh. We might need to use it before we receive the new token.
Return null from the refresh if we can't obtain a token.
Call checkBearerToken() on initial load, if no token is present in the URL.
Copy link
Contributor

@simoneduca simoneduca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eatyourgreens eatyourgreens merged commit 9ee2d22 into master Feb 23, 2018
@eatyourgreens eatyourgreens deleted the oauth-refresh-token branch February 23, 2018 16:30
@eatyourgreens
Copy link
Contributor Author

Published as 2.9.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants