[WIP] edit error handling for object with status and response #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcbouslog
commented
Mar 10, 2017
| @@ -6,22 +6,21 @@ var apiClient = new JSONAPIClient(config.host + '/api', { | |||
| 'Accept': 'application/vnd.api+json; version=1', | |||
| }, { | |||
| beforeEveryRequest: function() { | |||
| console.log('using local panoptes-client'); | |||
There was a problem hiding this comment.
will remove, keeping while linking dependencies via GitHub branches.
| @@ -33,19 +32,25 @@ var apiClient = new JSONAPIClient(config.host + '/api', { | |||
| } else { | |||
| errorMessage = 'Unknown error (bad response body)'; | |||
| } | |||
| } else if (response.text.indexOf('<!DOCTYPE') !== -1) { | |||
| } else if (error.response.text.indexOf('<!DOCTYPE') !== -1) { | |||
| // Manually set a reasonable error when we get HTML back (currently 500s will do this). | |||
There was a problem hiding this comment.
If we have the status code in the response, why are we sniffing the response body to test for a 500 error?
| error.message = errorMessage; | ||
| } | ||
|
|
||
| throw error; | ||
| } |
There was a problem hiding this comment.
Can you call throw with something that isn't an instance of Error?
| if (response.body.error_description) { | ||
| errorMessage += ' ' + response.error_description; | ||
| if (typeof error.response.body === 'object') { | ||
| if (error.response.body.error) { |
There was a problem hiding this comment.
error.response.body.error is pretty convoluted, and confusing, here.
There was a problem hiding this comment.
Errors should maybe follow the JSON API spec for error objects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not ready for merge, creating for discussion.
This is the 2nd PR to be merged in relation to improving API error handling.
1st to be merged would be the related PR in
json-api-client, which contains more context and questions.