Auto refresh bearer token #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var refresh = this._refreshBearerToken.bind(this, response.refresh_token); | ||
| var timeToRefresh = (response.expires_in * 1000) - TOKEN_EXPIRATION_ALLOWANCE; | ||
| this._bearerRefreshTimeout = setTimeout(refresh, timeToRefresh); | ||
| this._bearerTokenExpiration = Date.now() + (response.expires_in * 1000); |
There was a problem hiding this comment.
It's pretty minor, but it might be safer to use
this._bearerTokenExpiration = new Date(response.created_at * 1000) + (response.expires_in * 1000);There was a problem hiding this comment.
I think the way I've got it means the expiration time is relative to the user's clock, and this would make it relative to the server's clock. Isn't that a little safer?
There was a problem hiding this comment.
I see what you're saying. Using Date.now() should be within the allowance anyway.
Nope, this is working for me with some simulated expirations. Happy to go this route. |
|
👍 |
This was referenced May 17, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on zooniverse/json-api-client#30.
Instead of using
setTimeoutto fetch a new bearer token before the current one expires, this gives the auth module acheckBearerTokenmethod (which will refresh if needed) and calls ifbeforeEveryRequeston the API client.We also talked about refreshing the token and remaking requests when we get a 401, which I thought would require a major rewrite, but now that I think about it again it might not be a big deal. Any strong preference for me to look into it more?
(The
handleErrormethod is just moved, add&w=1to the PR URL to ignore it.)