Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak stats client for consistency, stub out a test #44

Merged
merged 1 commit into from
May 9, 2016

Conversation

brian-c
Copy link
Contributor

@brian-c brian-c commented May 9, 2016

Minor updates for more consistent style with the rest of the library. Mainly workflowID, not workflow_id.

Also stubbed in a dumb test just to see how it works.

@eatyourgreens
Copy link
Contributor

Looks good to me.

@eatyourgreens eatyourgreens merged commit b9752f9 into master May 9, 2016
@eatyourgreens eatyourgreens deleted the stats-client-update branch May 9, 2016 15:36
@CKrawczyk
Copy link
Contributor

@brian-c it looks like the test you added calls the stats function with params wrokflow_id and project_id instead of workflowID and projectID. As it is written the test is grabbing the events for all projects instead of for GZ bars.

@brian-c
Copy link
Contributor Author

brian-c commented May 10, 2016

Thanks @CKrawczyk, just pushed up a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants