-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix broken entry point in package.json, add development strings #38
Conversation
@amyrebecca Good catch. Mind deleting the unused root index.js file? @wgranger This will very likely fix the path resolution issue we couldn't figure out yesterday. |
To be honest this was @camallen's catch and I'm mopping up after, but we were collaborating on fixing the weird behavior of react-native. I'll add the index.js cleanup to my PR, that's also wise. |
Wait, is index.js actually unused? it looks like i could say
|
It's unused in PFE, and since "main" is defined you can now do `import apiClient from 'panoptes-client'. Either define "main" or include an index.js, but not both. I'd go the "main" route since index.js as it's currently built includes a bunch of code that you're probably not intending to include. |
That makes sense to me. I've done what you suggested. |
Awesome, thanks. I'll merge and bump the patch version and publish in just a minute. |
This was a breaking change :( |
Yes, this fixed a bug that I was unaware people were depending on. Had I known people depended on the broken behavior, I'd've bumped the major. Sorry. |
Ahh, no biggie. I think browserify must fall back to |
We are having trouble consuming panoptes-client npm package because the main in package.json was set to a file that no longer exists. This pull request fixes that, as well as adding strings to make "development" a meaningful environment name in addition to staging.
The npm package will need to be version-bumped after this change is accepted.