Auth clients: Hide private data from exports #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Export only public methods for the first-party auth client.
Export only public methods for the third-party auth client.
eatyourgreens
added
the
security
|
I've been able to classify cards on Every Name Counts without problems. Classified subjects show up in my Recents, so auth headers are being sent properly. Comments error on Talk staging, but I see the same errors on master. |
|
Some consuming apps use the return value from |
Add the listen and stopListening methods. Organise the exports in alphabetical order.
eatyourgreens
force-pushed
the
private-data
branch
from
3e1e276 to
5681ae3
Compare
|
I've added |
|
Nice. LGTM |
wgranger
approved these changes
Jun 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hide underscored methods and properties from the exported
authandoauthclients.Change the signature ofauth.checkBearerToken()so that it resolves true/false rather than resolving with the bearer token.npm install zooniverse/panoptes-javascript-client#private-datato try this out.