Check for Custom ENV Variable from CRA #128
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a check in the config file for an environment variable set via Create React App. This is necessary for deploying ALICE to staging.
ALICE is built using Create React App, which strictly sets
NODE_ENV
toproduction
when runningreact-scripts build
. Although you can set custom variables (likeREACT_APP_ENV
), you are not allowed to change the node environment (see Special Thanks on link), as it is strictly set.You can eject Create React App to set the
NODE_ENV
, but this is a pretty drastic thing to do, and you lose all the convenience of having CRA handle your dependencies.