Change default oAuth Host and allow config #126
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
This PR changes PJC's oAuth host:
www.zooniverse.org
instead ofpanoptes.zooniverse.org
, to reflect current changes to the backend. That's right! oAuth users now sign in via our "main domain" instead of thepanoptes.
sub-domain.?oauth-host=...
in the browser, or settingOAUTH_HOST
in the env build variables. This brings the oAuth host config setting in line with other editable items in the PJC's config.To Custom Front End developers:
*.zooniverse.org
domains (if you use the oauth.js code)Tested using a local copy of PJC and localhost Education API Front End, which was used to verify the single sign on.
Status
Ready for review. If all goes well, this might only require a minor version bump since it's not breaking any existing functionality - but let me know if you think otherwise.