Remove tests we don't trust #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camallen
approved these changes
Nov 26, 2019
There was a problem hiding this comment.
It would be good to know why these tests fail, i kept getting a failure when parsing the json response object after registering (API side was a 201 response).
I'm ok with removing these in favour of integration testing, though it would have been ideal to replace these with decent unit tests.
Is there any way we can automate the integration tests using something like https://github.com/puppeteer/puppeteer ?
|
Yeah puppeteer should work. I'd also use nock. We'll need to circle back to this soon. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The auth tests weren't trustworthy for #121, so this removes them, because bad tests are worse than no tests.